Skip to content

Commit d039081

Browse files
committed
Fix issue where user guide_kw are ignored
1 parent 74afbe6 commit d039081

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

proplot/internals/guides.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,10 @@ def _add_guide_kw(name, kwargs, **opts):
2626
"""
2727
Add to the `colorbar_kw` or `legend_kw` dict if there are no conflicts.
2828
"""
29-
# NOTE: Here we *do not* want to overwrite properties in the dictionary.
30-
# Indicates e.g. calling colorbar(extend='both') after pcolor(extend='neither').
29+
# NOTE: Here we *do not* want to overwrite properties in dictionary. Indicates
30+
# e.g. default locator inferred from levels or default title inferred from metadata.
3131
kwargs = kwargs.setdefault(f'{name}_kw', {})
32-
_update_kw(kwargs, overwrite=True, **opts)
32+
_update_kw(kwargs, overwrite=False, **opts)
3333

3434

3535
def _cache_guide_kw(obj, name, kwargs):
@@ -51,8 +51,8 @@ def _flush_guide_kw(obj, name, kwargs):
5151
"""
5252
Flux settings cached on the object into the keyword arguments.
5353
"""
54-
# NOTE: Here we *do* want to overwrite properties in dictionary. Indicates
55-
# updating kwargs during parsing (probably only relevant for ax.parametric).
54+
# NOTE: Here we *do not* overwrite properties in the dictionary by default.
55+
# Indicates e.g. calling colorbar(extend='both') after pcolor(extend='neither').
5656
# NOTE: Previously had problems reusing same keyword arguments for more than one
5757
# colorbar() because locator or formatter axis would get reset. Old solution was
5858
# to delete the _guide_kw but that destroyed default behavior. New solution is

0 commit comments

Comments
 (0)