Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pronto doesn't seem to compare files if they only changed file mode #429

Open
renatolond opened this issue Jun 30, 2022 · 1 comment
Open
Labels
bug help wanted Get involved! We'd love to have your help.

Comments

@renatolond
Copy link
Contributor

Hi! Thanks for your work in pronto :)

rubocop has a check for executables files without the right permission:

run:1:1: W: Lint/ScriptPermission: Script file run doesn't have execute permission.
#!/usr/bin/env ruby
^^^^^^^^^^^^^^^^^^^

1 file inspected, 1 offense detected, 1 offense auto-correctable

However, if I change the file mode, it seems pronto does not run rubocop on this file:

diff --git a/run b/run
old mode 100755
new mode 100644
@ashkulz
Copy link
Member

ashkulz commented Jan 11, 2025

@renatolond happy to accept PRs which fix this -- I suspect the bug is in this file.

@ashkulz ashkulz added bug help wanted Get involved! We'd love to have your help. labels Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug help wanted Get involved! We'd love to have your help.
Projects
None yet
Development

No branches or pull requests

2 participants