chore: enable several rules from go-critic #1478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmorel-35
changed the title
mmorel-35
force-pushed
the
gocritic
branch
2 times, most recently
from
ccbf5bb to
70b2dad
Compare
Member
|
Needs a rebase. |
Signed-off-by: Matthieu MOREL <[email protected]>
Signed-off-by: Matthieu MOREL <[email protected]>
Signed-off-by: Matthieu MOREL <[email protected]>
Signed-off-by: Matthieu MOREL <[email protected]>
Signed-off-by: Matthieu MOREL <[email protected]>
Signed-off-by: Matthieu MOREL <[email protected]>
Signed-off-by: Matthieu MOREL <[email protected]>
Signed-off-by: Matthieu MOREL <[email protected]>
Signed-off-by: Matthieu MOREL <[email protected]>
Signed-off-by: Matthieu MOREL <[email protected]>
Signed-off-by: Matthieu MOREL <[email protected]>
Member
|
Looks like #1482 added a new lint issue. 😹 |
Signed-off-by: Matthieu MOREL <[email protected]>
Centaro0
pushed a commit
to Centaro0/snmp-exporter
that referenced
this pull request
Oct 11, 2025
* chore: enable-all rules from go-critic Signed-off-by: Matthieu MOREL <[email protected]> * chore: enable emptyStringTest rule from go-critic Signed-off-by: Matthieu MOREL <[email protected]> * chore: enable exposedSyncMutex rule from go-critic Signed-off-by: Matthieu MOREL <[email protected]> * chore: enable ifElseChain rule from go-critic Signed-off-by: Matthieu MOREL <[email protected]> * chore: enable nestingReduce rule from go-critic Signed-off-by: Matthieu MOREL <[email protected]> * chore: enable regexpMust rule from go-critic Signed-off-by: Matthieu MOREL <[email protected]> * chore: enable regexpSimplify rule from go-critic Signed-off-by: Matthieu MOREL <[email protected]> * chore: enable singleCaseSwitch rule from go-critic Signed-off-by: Matthieu MOREL <[email protected]> * chore: enable typeDefFirst rule from go-critic Signed-off-by: Matthieu MOREL <[email protected]> * chore: enable typeSwitchVar rule from go-critic Signed-off-by: Matthieu MOREL <[email protected]> * chore: enable unlambda rule from go-critic Signed-off-by: Matthieu MOREL <[email protected]> * fic paramTypeCombine Signed-off-by: Matthieu MOREL <[email protected]> --------- Signed-off-by: Matthieu MOREL <[email protected]> Signed-off-by: Centaro0 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable and fixes several go-critic rules