Skip to content

Alertmanager links are lost when using OAuth redirects #1424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sjparkinson opened this issue Jun 20, 2018 · 4 comments
Closed

Alertmanager links are lost when using OAuth redirects #1424

sjparkinson opened this issue Jun 20, 2018 · 4 comments

Comments

@sjparkinson
Copy link

sjparkinson commented Jun 20, 2018

What did you do?

Setup OAuth in a reverse proxy to secure Alertmanager.

What did you expect to see?

Alertmanager links would be preserved when redirected through the OAuth redirection-based flow.

What did you see instead? Under which circumstances?

The anchor element of Alertmanagers links are not visible to the reverse proxy and so are lost when redirecting through the OAuth flow.

Environment

  • Alertmanager version: v0.14.0
@sjparkinson
Copy link
Author

For example, if I visit a link, https://alertmanager/#/alerts?filter=%7Balertname%3D%22Target%20Unavailable%22%2C%20system%3D%22zabbix%22%7D, but I'm not logged into the OAuth provider, the reverse proxy cannot read the anchor from the request and so it's not included in the redirect_uri parameter of the OAuth request.

@brancz
Copy link
Member

brancz commented Jun 20, 2018

Are you sure this doesn't have anything to do with your oauth proxy? If you are using the bitly/oauth2_proxy then I can confidently say it's not a problem with the Alertmanager but with the proxy, as I have a pending pull request to fix this 🙂 (RE: bitly/oauth2_proxy#483).

@sjparkinson
Copy link
Author

Ah! That is exactly what we're trying out!

@sjparkinson
Copy link
Author

I'll close this and watch that issue. Wonderful, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants