Fix an issue with blackbox exporter — array of depencencies was a string

Signed-off-by: Kuba Orlik <[email protected]>

Author: kuba-orlik

roles/_common/meta/argument_specs.yml

@@ -77,10 +77,10 @@ argument_specs:
     options:
       _common_dependencies:
         description: "Package dependencies to install"
-        default: "{% if (ansible_facts['pkg_mgr'] == 'apt') %}\
-                  {{ ('python-apt' if ansible_facts['python_version'] is version('3', '<') else 'python3-apt') }}
-                  {% else %}\
-                  {% endif %}"
+        default: >-
+          {{ ['python-apt'] if ansible_facts['pkg_mgr'] == 'apt' and ansible_facts['python_version'] is version('3', '<')
+             else ['python3-apt'] if ansible_facts['pkg_mgr'] == 'apt'
+             else [] }}
       _common_web_listen_address:
         description: "Address on which to listen"
         default: ""

roles/_common/tasks/preflight.yml

@@ -55,9 +55,9 @@
 - name: Install dependencies
   become: true
   ansible.builtin.package:
-    name: "{{ _common_dependencies }}"
+    name: "{{ item }}"
     state: present
-  when: (_common_dependencies != None)
+  loop: "{{_common_dependencies}}"
   tags:
     - "{{ ansible_parent_role_names | first | regex_replace(ansible_collection_name ~ '.', '') }}"
     - configure

roles/_common/vars/main.yml

@@ -10,10 +10,10 @@ _common_selinux_port: ""
 _common_service_name: "{{ __common_parent_role_short_name }}"
 _common_system_user: ""
 _common_system_group: ""
-_common_dependencies: "{% if (ansible_facts['pkg_mgr'] == 'apt') %}\
-                       {{ ('python-apt' if ansible_facts['python_version'] is version('3', '<') else 'python3-apt') }}
-                       {% else %}\
-                       {% endif %}"
+_common_dependencies: >-
+  {{ ['python-apt'] if ansible_facts['pkg_mgr'] == 'apt' and ansible_facts['python_version'] is version('3', '<')
+     else ['python3-apt'] if ansible_facts['pkg_mgr'] == 'apt'
+     else [] }}
 _common_binary_unarchive_opts: ""
 _common_tls_server_config: {}
 _common_http_server_config: {}

roles/blackbox_exporter/vars/main.yml

@@ -7,7 +7,8 @@ _blackbox_exporter_go_ansible_arch: "{{ {'i386': '386',
 _blackbox_exporter_repo: "prometheus/blackbox_exporter"
 _github_api_headers: "{{ {'GITHUB_TOKEN': lookup('ansible.builtin.env', 'GITHUB_TOKEN')} if (lookup('ansible.builtin.env', 'GITHUB_TOKEN')) else {} }}"
 _blackbox_exporter_binaries: ['blackbox_exporter']
-_blackbox_exporter_dependencies: "{% if (ansible_facts['pkg_mgr'] == 'apt') %}\
-                                  {{ (['python-apt', 'libcap2-bin'] if ansible_facts['python_version'] is version('3', '<') else ['python3-apt', 'libcap2-bin']) }}
-                                  {% else %}\
-                                  {% endif %}"
+_blackbox_exporter_dependencies: >-
+  {{ ['python-apt', 'libcap2-bin']
+     if ansible_facts['pkg_mgr'] == 'apt' and ansible_facts['python_version'] is version('3', '<')
+     else ['python3-apt', 'libcap2-bin'] if ansible_facts['pkg_mgr'] == 'apt'
+     else [] }}