Fix up errcheck linting.

Signed-off-by: SuperQ <[email protected]>

Author: SuperQ

.golangci.yml

@@ -0,0 +1,4 @@
+---
+linters-settings:
+  errcheck:
+    exclude: scripts/errcheck_excludes.txt

cmd/client/main.go

@@ -166,6 +166,7 @@ func (c *Coordinator) doPush(resp *http.Response, origRequest *http.Request, cli
 	url := base.ResolveReference(u)
 
 	buf := &bytes.Buffer{}
+	//nolint:errcheck // https://github.com/prometheus-community/PushProx/issues/111
 	resp.Write(buf)
 	request := &http.Request{
 		Method:        "POST",

cmd/proxy/main.go

@@ -150,6 +150,7 @@ func (h *httpHandler) handlePoll(w http.ResponseWriter, r *http.Request) {
 		http.Error(w, fmt.Sprintf("Error WaitForScrapeInstruction: %s", err.Error()), 408)
 		return
 	}
+	//nolint:errcheck // https://github.com/prometheus-community/PushProx/issues/111
 	request.WriteProxy(w) // Send full request as the body of the response.
 	level.Info(h.logger).Log("msg", "Responded to /poll", "url", request.URL.String(), "scrape_id", request.Header.Get("Id"))
 }
@@ -161,6 +162,7 @@ func (h *httpHandler) handleListClients(w http.ResponseWriter, r *http.Request)
 	for _, k := range known {
 		targets = append(targets, &targetGroup{Targets: []string{k}})
 	}
+	//nolint:errcheck // https://github.com/prometheus-community/PushProx/issues/111
 	json.NewEncoder(w).Encode(targets)
 	level.Info(h.logger).Log("msg", "Responded to /clients", "client_count", len(known))
 }

scripts/errcheck_excludes.txt

@@ -0,0 +1,8 @@
+// Don't flag lines such as "io.Copy(ioutil.Discard, resp.Body)".
+io.Copy
+// The next two are used in HTTP handlers, any error is handled by the server itself.
+io.WriteString
+(net/http.ResponseWriter).Write
+
+// Never check for logger errors.
+(github.com/go-kit/kit/log.Logger).Log