fix(fluent-syntax): Use correct TS type for clone() return (#589)

eemeli · eemeli · commit 788e4df7d2ac · 2022-04-28T15:27:20.000+03:00
diff --git a/fluent-syntax/src/ast.ts b/fluent-syntax/src/ast.ts
@@ -47,7 +47,7 @@ export abstract class BaseNode {
     return true;
   }
 
-  clone(): BaseNode {
+  clone(): this {
     function visit(value: unknown): unknown {
       if (value instanceof BaseNode) {
         return value.clone();
@@ -58,7 +58,7 @@ export abstract class BaseNode {
       return value;
     }
     // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
-    const clone = Object.create(this.constructor.prototype) as BaseNode;
+    const clone = Object.create(this.constructor.prototype) as this;
     for (const prop of Object.keys(this)) {
       clone[prop] = visit(this[prop]);
     }

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ export abstract class BaseNode {`
`47`	`47`	`return true;`
`48`	`48`	`}`
`49`	`49`
`50`		`- clone(): BaseNode {`
	`50`	`+ clone(): this {`
`51`	`51`	`function visit(value: unknown): unknown {`
`52`	`52`	`if (value instanceof BaseNode) {`
`53`	`53`	`return value.clone();`
`@@ -58,7 +58,7 @@ export abstract class BaseNode {`
`58`	`58`	`return value;`
`59`	`59`	`}`
`60`	`60`	`// eslint-disable-next-line @typescript-eslint/no-unsafe-argument`
`61`		`- const clone = Object.create(this.constructor.prototype) as BaseNode;`
	`61`	`+ const clone = Object.create(this.constructor.prototype) as this;`
`62`	`62`	`for (const prop of Object.keys(this)) {`
`63`	`63`	`clone[prop] = visit(this[prop]);`
`64`	`64`	`}`