Skip to content

Commit 2033e5e

Browse files
committed
Make leaflet an NPM dependency
1 parent 501f536 commit 2033e5e

File tree

6 files changed

+9
-8
lines changed

6 files changed

+9
-8
lines changed

app/assets/javascripts/spotlight/admin/index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
//= require bootstrap-tagsinput
77
//= require jquery.serializejson
88
//= require clipboard/dist/clipboard
9-
//= require leaflet
9+
//= require leaflet/dist/leaflet-src
1010
//= require leaflet-iiif
1111
//= require Leaflet.Editable
1212
//= require Path.Drag

blacklight-spotlight.gemspec

-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ these collections.)
4040
s.add_dependency 'i18n-active_record'
4141
s.add_dependency 'iiif_manifest'
4242
s.add_dependency 'iiif-presentation'
43-
s.add_dependency 'leaflet-rails'
4443
s.add_dependency 'legato'
4544
s.add_dependency 'mini_magick'
4645
s.add_dependency 'nokogiri'

lib/generators/spotlight/install_generator.rb

+5-3
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,6 @@ def add_js_rails6
2727
# but since webpacker exists in the gemfile, we still need to run the
2828
# install before rails will start
2929
run 'bundle exec rails webpacker:install'
30-
31-
say 'Install Clipboard'
32-
run 'yarn add [email protected]'
3330
end
3431

3532
def add_js_rails7
@@ -38,6 +35,11 @@ def add_js_rails7
3835
append_to_file 'app/assets/javascripts/application.js', "\n//= require_tree .\n"
3936
end
4037

38+
def add_js_deps
39+
say 'Install Clipboard & Leaflet'
40+
run 'yarn add [email protected] leaflet@^1.9.3'
41+
end
42+
4143
def add_manifest
4244
append_to_file 'app/assets/config/manifest.js', "\n//= link spotlight/manifest.js"
4345
end

lib/generators/spotlight/templates/spotlight.scss

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,5 @@
44
@import 'spotlight/variables_bootstrap';
55
@import 'bootstrap';
66
@import 'sir-trevor/main';
7-
@import 'leaflet';
7+
@import 'leaflet/dist/leaflet';
88
@import 'spotlight/spotlight';

lib/spotlight/engine.rb

-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
require 'faraday/follow_redirects'
1414
require 'friendly_id'
1515
require 'i18n/active_record'
16-
require 'leaflet-rails'
1716
require 'paper_trail'
1817
require 'riiif'
1918
require 'spotlight/riiif_service'

package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
"not IE 11"
2626
],
2727
"dependencies": {
28-
"clipboard": "1.7.1"
28+
"clipboard": "1.7.1",
29+
"leaflet": "^1.9.3"
2930
}
3031
}

0 commit comments

Comments
 (0)