Skip to content

Commit fce7833

Browse files
committed
NCL-9179 Add MVN RPM build type
1 parent e577950 commit fce7833

File tree

5 files changed

+8
-3
lines changed

5 files changed

+8
-3
lines changed

src/common/buildConfigEntityAttributes.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { Build, BuildConfiguration } from 'pnc-api-types-ts';
22

33
import { TEntityAttributes } from 'common/entityAttributes';
44

5-
const buildTypeValues: BuildConfiguration['buildType'][] = ['MVN', 'NPM', 'GRADLE', 'SBT'];
5+
const buildTypeValues: BuildConfiguration['buildType'][] = ['MVN', 'NPM', 'GRADLE', 'SBT', 'MVN_RPM'];
66

77
interface IExtendedBuildConfig extends BuildConfiguration {
88
buildStatus: Build['status'];

src/common/buildTypeData.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,4 +26,8 @@ export const buildTypeData: TBuildTypeData = {
2626
id: 'SBT',
2727
title: 'Scala Build Tool (SBT)',
2828
},
29+
MVN_RPM: {
30+
id: 'MVN_RPM',
31+
title: 'Maven RPM',
32+
},
2933
} as const;

src/common/colorMap.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ export const buildTypeColorMap: Record<string, LabelConfig> = {
1212
NPM: { text: 'NPM', color: 'purple', hexColor: '#CBC1FF' }, // purple-100
1313
GRADLE: { text: 'GRADLE', color: 'cyan', hexColor: '#A2D9D9' }, // cyan-100
1414
SBT: { text: 'SBT', color: 'grey', hexColor: '#D2D2D2' }, // black-300
15+
MVN_RPM: { text: 'MVN_RPM', color: 'orange', hexColor: '#F4B678' }, // orange-100
1516
};
1617

1718
export const artifactQualityColorMap: Record<string, LabelConfig> = {

src/components/BuildConfigCreateEditPage/BuildConfigCreateEditPage.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ const generateAlignmentParametersDescription = (buildType: BuildConfiguration['b
146146
}
147147

148148
const cliProject =
149-
buildType === buildTypeData.MVN.id
149+
buildType === buildTypeData.MVN.id || buildType === buildTypeData.MVN_RPM.id
150150
? { name: 'PME', url: 'https://release-engineering.github.io/pom-manipulation-ext/#feature-guide' }
151151
: buildType === buildTypeData.GRADLE.id
152152
? { name: 'GME', url: 'https://project-ncl.github.io/gradle-manipulator/#feature-guide' }

src/utils/formValidationHelpers.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,7 @@ const buildScriptChecker = (
231231
export const validateBuildScript = (fieldValues: IFieldValues, options?: IBuildScriptCheckerOptions): boolean => {
232232
return (
233233
!fieldValues.buildScript ||
234-
fieldValues.buildType !== buildTypeData.MVN.id ||
234+
(fieldValues.buildType !== buildTypeData.MVN.id && fieldValues.buildType !== buildTypeData.MVN_RPM.id) ||
235235
buildScriptChecker(fieldValues.buildScript, options)
236236
);
237237
};

0 commit comments

Comments
 (0)