Skip to content

Commit c131a44

Browse files
committed
Yeah we have to go through headers
The Rex mdc configuraiton is a bit misleading
1 parent 74dcc9a commit c131a44

File tree

7 files changed

+32
-11
lines changed

7 files changed

+32
-11
lines changed

application/src/main/java/org/jboss/pnc/dingrogu/application/runtime/LoggingFilter.java

+1
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ public void filter(ContainerRequestContext requestContext) {
4444
Request request = requestContext.getRequest();
4545
log.info("== Request {} {}.", request.getMethod(), uriInfo.getRequestUri());
4646
Map<String, String> mdcContext = getContextMap();
47+
// TODO: can we just create a for loop with a ll the values?
4748
headerToMap(mdcContext, MDCHeaderKeys.PROCESS_CONTEXT, requestContext);
4849
headerToMap(mdcContext, MDCHeaderKeys.TMP, requestContext);
4950
headerToMap(mdcContext, MDCHeaderKeys.EXP, requestContext);

common/src/main/java/org/jboss/pnc/dingrogu/common/TaskHelper.java

+6-4
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,11 @@
22

33
import jakarta.ws.rs.core.MediaType;
44
import org.jboss.pnc.api.dto.Request;
5+
import org.jboss.pnc.common.log.MDCUtils;
56

67
import java.util.ArrayList;
78
import java.util.List;
9+
import java.util.Map;
810

911
public class TaskHelper {
1012

@@ -17,10 +19,10 @@ public static List<Request.Header> getHTTPHeaders() {
1719
headers.add(JSON_HEADER);
1820
headers.add(ACCEPT_JSON_HEADER);
1921

20-
// Map<String, String> mdcMap = MDCUtils.getHeadersFromMDC();
21-
// if (mdcMap != null) {
22-
// mdcMap.forEach((key, value) -> headers.add(new Request.Header(key, value)));
23-
// }
22+
Map<String, String> mdcMap = MDCUtils.getHeadersFromMDC();
23+
if (mdcMap != null) {
24+
mdcMap.forEach((key, value) -> headers.add(new Request.Header(key, value)));
25+
}
2426

2527
return headers;
2628
}

rest-adapter/src/main/java/org/jboss/pnc/dingrogu/restadapter/adapter/DummyAdapter.java

-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ public class DummyAdapter implements Adapter<DummyDTO> {
3838

3939
@Override
4040
public void start(String correlationId, StartRequest startRequest) {
41-
4241
Map<String, String> mdcMap = startRequest.getMdc();
4342
for (String key : mdcMap.keySet()) {
4443
log.info("Adapter start mdc: {}::{}", key, mdcMap.get(key));

rest-workflow/src/main/java/org/jboss/pnc/dingrogu/restworkflow/workflows/BuildWorkflow.java

+1-3
Original file line numberDiff line numberDiff line change
@@ -78,9 +78,7 @@ public CorrelationId submitWorkflow(BuildWorkDTO buildWorkDTO) throws WorkflowSu
7878
Set<EdgeDTO> edges = Set.of(alignToRepoSetup, repoSetupToRepoSeal, repoSealToRepoPromote);
7979

8080
ConfigurationDTO configurationDTO = ConfigurationDTO.builder()
81-
.mdcHeaderKeyMapping(MDCUtils.getHeadersFromMDC())
82-
.passMDCInRequestBody(true)
83-
.passOTELInRequestBody(true)
81+
.mdcHeaderKeyMapping(MDCUtils.HEADER_KEY_MAPPING)
8482
.build();
8583
CreateGraphRequest graphRequest = new CreateGraphRequest(
8684
correlationId.getId(),

rest-workflow/src/main/java/org/jboss/pnc/dingrogu/restworkflow/workflows/DeliverablesAnalysisWorkflow.java

+10-1
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,15 @@
33
import jakarta.enterprise.context.ApplicationScoped;
44
import jakarta.inject.Inject;
55
import org.eclipse.microprofile.config.inject.ConfigProperty;
6+
import org.jboss.pnc.common.log.MDCUtils;
67
import org.jboss.pnc.dingrogu.api.client.RexClient;
78
import org.jboss.pnc.dingrogu.api.dto.CorrelationId;
89
import org.jboss.pnc.dingrogu.api.dto.adapter.DeliverablesAnalyzerDTO;
910
import org.jboss.pnc.dingrogu.api.dto.adapter.OrchDeliverablesAnalyzerResultDTO;
1011
import org.jboss.pnc.dingrogu.api.dto.workflow.DeliverablesAnalysisWorkflowDTO;
1112
import org.jboss.pnc.dingrogu.restadapter.adapter.DeliverablesAnalyzerAdapter;
1213
import org.jboss.pnc.dingrogu.restadapter.adapter.OrchDeliverablesAnalyzerResultAdapter;
14+
import org.jboss.pnc.rex.dto.ConfigurationDTO;
1315
import org.jboss.pnc.rex.dto.CreateTaskDTO;
1416
import org.jboss.pnc.rex.dto.EdgeDTO;
1517
import org.jboss.pnc.rex.dto.requests.CreateGraphRequest;
@@ -64,7 +66,14 @@ public CorrelationId submitWorkflow(DeliverablesAnalysisWorkflowDTO dto) throws
6466
EdgeDTO edgeDTO = EdgeDTO.builder().source(taskResult.name).target(taskAnalyze.name).build();
6567
Set<EdgeDTO> edges = Set.of(edgeDTO);
6668

67-
CreateGraphRequest graphRequest = new CreateGraphRequest(correlationId.getId(), null, edges, vertices);
69+
ConfigurationDTO configurationDTO = ConfigurationDTO.builder()
70+
.mdcHeaderKeyMapping(MDCUtils.HEADER_KEY_MAPPING)
71+
.build();
72+
CreateGraphRequest graphRequest = new CreateGraphRequest(
73+
correlationId.getId(),
74+
configurationDTO,
75+
edges,
76+
vertices);
6877
rexClient.submitWorkflow(graphRequest);
6978

7079
return correlationId;

rest-workflow/src/main/java/org/jboss/pnc/dingrogu/restworkflow/workflows/DummyWorkflow.java

+9-1
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
import org.jboss.pnc.dingrogu.api.dto.adapter.DummyDTO;
1111
import org.jboss.pnc.dingrogu.api.dto.workflow.DummyWorkflowDTO;
1212
import org.jboss.pnc.dingrogu.restadapter.adapter.DummyAdapter;
13+
import org.jboss.pnc.rex.dto.ConfigurationDTO;
1314
import org.jboss.pnc.rex.dto.CreateTaskDTO;
1415
import org.jboss.pnc.rex.dto.EdgeDTO;
1516
import org.jboss.pnc.rex.dto.requests.CreateGraphRequest;
@@ -51,7 +52,14 @@ public CorrelationId submitWorkflow(DummyWorkflowDTO dummyWorkflowDTO) throws Wo
5152
// Set<EdgeDTO> edges = Set.of(edgeDTO);
5253
Set<EdgeDTO> edges = Set.of();
5354

54-
CreateGraphRequest graphRequest = new CreateGraphRequest(correlationId.getId(), null, edges, vertices);
55+
ConfigurationDTO configurationDTO = ConfigurationDTO.builder()
56+
.mdcHeaderKeyMapping(org.jboss.pnc.common.log.MDCUtils.HEADER_KEY_MAPPING)
57+
.build();
58+
CreateGraphRequest graphRequest = new CreateGraphRequest(
59+
correlationId.getId(),
60+
configurationDTO,
61+
edges,
62+
vertices);
5563
rexClient.submitWorkflow(graphRequest);
5664

5765
return correlationId;

rest-workflow/src/main/java/org/jboss/pnc/dingrogu/restworkflow/workflows/RepositoryCreationWorkflow.java

+5-1
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
import org.jboss.pnc.dingrogu.api.dto.adapter.RepourCreateRepositoryDTO;
1010
import org.jboss.pnc.dingrogu.restadapter.adapter.RepourCloneRepositoryAdapter;
1111
import org.jboss.pnc.dingrogu.restadapter.adapter.RepourCreateRepositoryAdapter;
12+
import org.jboss.pnc.rex.dto.ConfigurationDTO;
1213
import org.jboss.pnc.rex.dto.CreateTaskDTO;
1314
import org.jboss.pnc.rex.dto.EdgeDTO;
1415
import org.jboss.pnc.rex.dto.requests.CreateGraphRequest;
@@ -88,6 +89,9 @@ CreateGraphRequest generateWorkflow(CorrelationId correlationId, RepositoryCreat
8889
EdgeDTO edgeDTO = EdgeDTO.builder().source(taskCloneScm.name).target(taskInternalScm.name).build();
8990
Set<EdgeDTO> edges = Set.of(edgeDTO);
9091

91-
return new CreateGraphRequest(correlationId.getId(), null, edges, vertices);
92+
ConfigurationDTO configurationDTO = ConfigurationDTO.builder()
93+
.mdcHeaderKeyMapping(org.jboss.pnc.common.log.MDCUtils.HEADER_KEY_MAPPING)
94+
.build();
95+
return new CreateGraphRequest(correlationId.getId(), configurationDTO, edges, vertices);
9296
}
9397
}

0 commit comments

Comments
 (0)