Use URI::toURL to create URLs (#1382)

Author: dwalluck

cli/src/test/java/org/jboss/pnc/build/finder/cli/MainTest.java

@@ -20,6 +20,7 @@
 import static org.jboss.pnc.build.finder.core.ChecksumType.sha256;
 
 import java.io.IOException;
+import java.net.URI;
 import java.net.URL;
 import java.nio.file.Path;
 import java.util.Collection;
@@ -85,8 +86,8 @@ void testParsing(@TempDir Path folder) throws IOException {
         Path configFile = TestUtils.loadFile("config.json");
         Path inputFile = TestUtils.loadFile("nested.war");
 
-        URL hubURL = new URL("http://a.b");
-        URL webURL = new URL("http://c.d");
+        URL hubURL = URI.create("http://a.b").toURL();
+        URL webURL = URI.create("http://c.d").toURL();
         Path krbCcache = folder.resolve("krb5-cache");
         Path krbKeytab = folder.resolve("krb5-keytab");
         String krbPassword = "test";

core/src/test/java/org/jboss/pnc/build/finder/core/CompletedAndDeletedBuildTest.java

@@ -18,7 +18,7 @@
 import static org.assertj.core.api.Assertions.assertThat;
 
 import java.net.MalformedURLException;
-import java.net.URL;
+import java.net.URI;
 import java.util.Collection;
 import java.util.Collections;
 import java.util.LinkedHashMap;
@@ -44,7 +44,7 @@ class CompletedAndDeletedBuildTest extends AbstractWireMockTest {
     @BeforeAll
     static void setup() throws MalformedURLException {
         config = new BuildConfig();
-        config.setKojiHubURL(new URL(WIRE_MOCK_EXTENSION.baseUrl()));
+        config.setKojiHubURL(URI.create(WIRE_MOCK_EXTENSION.baseUrl()).toURL());
     }
 
     @Test

core/src/test/java/org/jboss/pnc/build/finder/core/CompletedBuildTest.java

@@ -18,7 +18,7 @@
 import static org.assertj.core.api.Assertions.assertThat;
 
 import java.net.MalformedURLException;
-import java.net.URL;
+import java.net.URI;
 import java.util.Collection;
 import java.util.Collections;
 import java.util.LinkedHashMap;
@@ -43,7 +43,7 @@ class CompletedBuildTest extends AbstractWireMockTest {
     @BeforeAll
     static void setup() throws MalformedURLException {
         config = new BuildConfig();
-        config.setKojiHubURL(new URL(WIRE_MOCK_EXTENSION.baseUrl()));
+        config.setKojiHubURL(URI.create(WIRE_MOCK_EXTENSION.baseUrl()).toURL());
     }
 
     @Test

core/src/test/java/org/jboss/pnc/build/finder/core/DeletedBuildTest.java

@@ -18,7 +18,7 @@
 import static org.assertj.core.api.Assertions.assertThat;
 
 import java.net.MalformedURLException;
-import java.net.URL;
+import java.net.URI;
 import java.util.Collection;
 import java.util.Collections;
 import java.util.LinkedHashMap;
@@ -43,7 +43,7 @@ class DeletedBuildTest extends AbstractWireMockTest {
     @BeforeAll
     static void setup() throws MalformedURLException {
         config = new BuildConfig();
-        config.setKojiHubURL(new URL(WIRE_MOCK_EXTENSION.baseUrl()));
+        config.setKojiHubURL(URI.create(WIRE_MOCK_EXTENSION.baseUrl()).toURL());
     }
 
     @Test

core/src/test/java/org/jboss/pnc/build/finder/core/EmptyBuildsTest.java

@@ -19,7 +19,7 @@
 
 import java.io.IOException;
 import java.net.MalformedURLException;
-import java.net.URL;
+import java.net.URI;
 import java.util.Collection;
 import java.util.Collections;
 import java.util.LinkedHashMap;
@@ -44,7 +44,7 @@ class EmptyBuildsTest extends AbstractWireMockTest {
     @BeforeAll
     static void setup() throws MalformedURLException {
         config = new BuildConfig();
-        config.setKojiHubURL(new URL(WIRE_MOCK_EXTENSION.baseUrl()));
+        config.setKojiHubURL(URI.create(WIRE_MOCK_EXTENSION.baseUrl()).toURL());
     }
 
     @Test

core/src/test/java/org/jboss/pnc/build/finder/core/SkipImportTest.java

@@ -18,7 +18,7 @@
 import static org.assertj.core.api.Assertions.assertThat;
 
 import java.net.MalformedURLException;
-import java.net.URL;
+import java.net.URI;
 import java.util.Collection;
 import java.util.Collections;
 import java.util.LinkedHashMap;
@@ -43,7 +43,7 @@ class SkipImportTest extends AbstractWireMockTest {
     @BeforeAll
     static void setup() throws MalformedURLException {
         config = new BuildConfig();
-        config.setKojiHubURL(new URL(WIRE_MOCK_EXTENSION.baseUrl()));
+        config.setKojiHubURL(URI.create(WIRE_MOCK_EXTENSION.baseUrl()).toURL());
     }
 
     @Test

core/src/test/java/org/jboss/pnc/build/finder/core/SpdxLicenseUtilsTest.java

@@ -21,6 +21,7 @@
 
 import java.io.IOException;
 import java.io.InputStream;
+import java.net.URI;
 import java.net.URL;
 import java.nio.file.Files;
 import java.nio.file.Path;
@@ -162,7 +163,7 @@ void testFindMatchingSPDXLicenseIdentifier() {
 
     @Test
     void testGetMatchingLicense(@TempDir Path folder) throws IOException, InvalidSPDXAnalysisException {
-        URL url = new URL("https://www.apache.org/licenses/LICENSE-2.0.txt");
+        URL url = URI.create("https://www.apache.org/licenses/LICENSE-2.0.txt").toURL();
         Path path = folder.resolve("LICENSE-2.0-1.txt");
 
         try (InputStream in = url.openStream()) {