Skip to content

Commit d7ffc96

Browse files
authored
[COST-5133] Switch to contains logic for Azure & GCP managed (#5301)
1 parent 08e578c commit d7ffc96

File tree

2 files changed

+8
-10
lines changed

2 files changed

+8
-10
lines changed

koku/masu/database/trino_sql/azure/openshift/managed_azure_openshift_daily.sql

+4-5
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ INSERT INTO hive.{{schema | sqlsafe}}.managed_azure_openshift_daily (
8888
day
8989
)
9090
WITH cte_azure_resource_names AS (
91-
SELECT DISTINCT resourceid, servicefamily
91+
SELECT DISTINCT resourceid
9292
FROM hive.{{schema | sqlsafe}}.azure_line_items
9393
WHERE source = {{azure_source_uuid}}
9494
AND year = {{year}}
@@ -115,14 +115,14 @@ cte_array_agg_volumes AS (
115115
AND interval_start < date_add('day', 1, {{end_date}})
116116
),
117117
cte_matchable_resource_names AS (
118-
SELECT resource_names.resourceid, resource_names.servicefamily
118+
SELECT resource_names.resourceid
119119
FROM cte_azure_resource_names AS resource_names
120120
JOIN cte_array_agg_nodes AS nodes
121121
ON strpos(resource_names.resourceid, nodes.node) != 0
122122

123123
UNION
124124

125-
SELECT resource_names.resourceid, resource_names.servicefamily
125+
SELECT resource_names.resourceid
126126
FROM cte_azure_resource_names AS resource_names
127127
JOIN cte_array_agg_volumes AS volumes
128128
ON (
@@ -186,8 +186,7 @@ SELECT azure.accountname,
186186
cast(day(azure.date) as varchar) as day
187187
FROM hive.{{schema | sqlsafe}}.azure_line_items AS azure
188188
LEFT JOIN cte_matchable_resource_names AS resource_names
189-
ON substr(azure.resourceid, -length(resource_names.resourceid)) = resource_names.resourceid
190-
AND azure.servicefamily = resource_names.servicefamily
189+
ON azure.resource_id = resource_names.resourceid
191190
LEFT JOIN cte_agg_tags AS tag_matches
192191
ON any_match(tag_matches.matched_tags, x->strpos(tags, x) != 0)
193192
AND resource_names.resourceid IS NULL

koku/masu/database/trino_sql/gcp/openshift/managed_gcp_openshift_daily.sql

+4-5
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ INSERT INTO hive.{{schema | sqlsafe}}.managed_gcp_openshift_daily (
6262
day
6363
)
6464
WITH cte_gcp_resource_names AS (
65-
SELECT DISTINCT resource_name, service_description
65+
SELECT DISTINCT resource_name
6666
FROM hive.{{schema | sqlsafe}}.gcp_line_items_daily
6767
WHERE source = {{gcp_source_uuid}}
6868
AND year = {{year}}
@@ -89,14 +89,14 @@ cte_array_agg_volumes AS (
8989
AND interval_start < date_add('day', 1, {{end_date}})
9090
),
9191
cte_matchable_resource_names AS (
92-
SELECT resource_names.resource_name, resource_names.service_description
92+
SELECT resource_names.resource_name
9393
FROM cte_gcp_resource_names AS resource_names
9494
JOIN cte_array_agg_nodes AS nodes
9595
ON strpos(resource_names.resource_name, nodes.node) != 0
9696

9797
UNION
9898

99-
SELECT resource_names.resource_name, resource_names.service_description
99+
SELECT resource_names.resource_name
100100
FROM cte_gcp_resource_names AS resource_names
101101
JOIN cte_array_agg_volumes AS volumes
102102
ON (
@@ -147,8 +147,7 @@ SELECT gcp.invoice_month,
147147
cast(day(gcp.usage_start_time) as varchar) as day
148148
FROM hive.{{schema | sqlsafe}}.gcp_line_items_daily AS gcp
149149
LEFT JOIN cte_matchable_resource_names AS resource_names
150-
ON substr(gcp.resource_name, -length(resource_names.resource_name)) = resource_names.resource_name
151-
AND gcp.service_description = resource_names.service_description
150+
ON gcp.resource_name = resource_names.resource_name
152151
LEFT JOIN cte_agg_tags AS tag_matches
153152
ON any_match(tag_matches.matched_tags, x->strpos(labels, x) != 0)
154153
AND resource_names.resource_name IS NULL

0 commit comments

Comments
 (0)