Skip to content

Commit 2bee4cd

Browse files
committed
refactor: generic resources
1 parent 41833f2 commit 2bee4cd

File tree

4 files changed

+329
-379
lines changed

4 files changed

+329
-379
lines changed

pkg/controller/queuejob/queuejob_controller_ex.go

+3-7
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ import (
5252
apierrors "k8s.io/apimachinery/pkg/api/errors"
5353
"k8s.io/apimachinery/pkg/api/meta"
5454
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
55-
"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
5655
"k8s.io/apimachinery/pkg/labels"
5756
"k8s.io/apimachinery/pkg/util/wait"
5857
"k8s.io/client-go/kubernetes"
@@ -582,13 +581,10 @@ func (qjm *XController) getAppWrapperCompletionStatus(caw *arbv1.AppWrapper) arb
582581
for i, genericItem := range caw.Spec.AggrResources.GenericItems {
583582
if len(genericItem.CompletionStatus) > 0 {
584583
objectName := genericItem.GenericTemplate
585-
var unstruct unstructured.Unstructured
586-
unstruct.Object = make(map[string]interface{})
587-
var blob interface{}
588-
if err := jsons.Unmarshal(objectName.Raw, &blob); err != nil {
589-
klog.Errorf("[getAppWrapperCompletionStatus] Error unmarshalling, err=%#v", err)
584+
unstruct, err := genericresource.UnmarshalToUnstructured(objectName.Raw)
585+
if err != nil {
586+
klog.Errorf("[getAppWrapperCompletionStatus] Error: %v", err)
590587
}
591-
unstruct.Object = blob.(map[string]interface{}) // set object to the content of the blob after Unmarshalling
592588
name := ""
593589
if md, ok := unstruct.Object["metadata"]; ok {
594590
metadata := md.(map[string]interface{})

0 commit comments

Comments
 (0)