Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 74cfe04

Browse files
committedMar 10, 2025··
fix(RHOAIENG-20531): adjusted formatting
Signed-off-by: Pat O'Connor <[email protected]>
1 parent 814f71f commit 74cfe04

File tree

6 files changed

+36
-10
lines changed

6 files changed

+36
-10
lines changed
 

‎poetry.lock

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,4 +59,4 @@ markers = [
5959
]
6060
addopts = "--timeout=900"
6161
testpaths = ["src/codeflare_sdk"]
62-
collect_ignore = ["src/codeflare_sdk/common/utils/unit_test_support.py"]
62+
collect_ignore = ["src/codeflare_sdk/common/utils/unit_test_support.py"]

‎src/codeflare_sdk/common/kueue/test_kueue.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,8 +101,7 @@ def test_aw_creation_local_queue(mocker):
101101
print("generated yaml")
102102
print(yaml.dump(aw_kueue, default_flow_style=False))
103103
print("expected yaml")
104-
print(yaml.dump(expected_rc, default_flow_style=False)
105-
)
104+
print(yaml.dump(expected_rc, default_flow_style=False))
106105
assert aw_kueue == expected_rc
107106

108107
# With resources loaded in memory, no Local Queue specified.

‎src/codeflare_sdk/common/utils/unit_test_support.py

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,11 @@ def create_cluster_config(num_workers=2, write_to_file=False):
4040
worker_memory_limits=6,
4141
appwrapper=True,
4242
write_to_file=write_to_file,
43-
annotations={"app.kubernetes.io/managed-by": "test-prefix", "key1": "value1", "key2": "value2"},
43+
annotations={
44+
"app.kubernetes.io/managed-by": "test-prefix",
45+
"key1": "value1",
46+
"key2": "value2",
47+
},
4448
)
4549
return config
4650

@@ -499,7 +503,11 @@ def create_cluster_all_config_params(mocker, cluster_name, is_appwrapper) -> Clu
499503
extended_resource_mapping={"example.com/gpu": "GPU", "intel.com/gpu": "TPU"},
500504
overwrite_default_resource_mapping=True,
501505
local_queue="local-queue-default",
502-
annotations={"app.kubernetes.io/managed-by": "test-prefix", "key1": "value1", "key2": "value2"},
506+
annotations={
507+
"app.kubernetes.io/managed-by": "test-prefix",
508+
"key1": "value1",
509+
"key2": "value2",
510+
},
503511
volumes=volumes,
504512
volume_mounts=volume_mounts,
505513
)

‎src/codeflare_sdk/ray/cluster/build_ray_cluster.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ def build_ray_cluster(cluster: "codeflare_sdk.ray.cluster.Cluster"):
145145
cluster,
146146
[get_head_container_spec(cluster)],
147147
cluster.config.head_tolerations,
148-
)
148+
),
149149
},
150150
},
151151
"workerGroupSpecs": [
@@ -165,7 +165,7 @@ def build_ray_cluster(cluster: "codeflare_sdk.ray.cluster.Cluster"):
165165
cluster,
166166
[get_worker_container_spec(cluster)],
167167
cluster.config.worker_tolerations,
168-
)
168+
),
169169
),
170170
}
171171
],

‎src/codeflare_sdk/ray/cluster/test_config.py

Lines changed: 21 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,17 @@ def test_default_cluster_creation(mocker):
3535
mocker.patch("kubernetes.client.ApisApi.get_api_versions")
3636
mocker.patch("kubernetes.client.CustomObjectsApi.list_namespaced_custom_object")
3737

38-
cluster = Cluster(ClusterConfiguration(name="default-cluster", namespace="ns", annotations={"app.kubernetes.io/managed-by": "test-prefix", "key1": "value1", "key2": "value2"}))
38+
cluster = Cluster(
39+
ClusterConfiguration(
40+
name="default-cluster",
41+
namespace="ns",
42+
annotations={
43+
"app.kubernetes.io/managed-by": "test-prefix",
44+
"key1": "value1",
45+
"key2": "value2",
46+
},
47+
)
48+
)
3949

4050
expected_rc = apply_template(
4151
f"{expected_clusters_dir}/ray/default-ray-cluster.yaml",
@@ -50,7 +60,16 @@ def test_default_appwrapper_creation(mocker):
5060
mocker.patch("kubernetes.client.CustomObjectsApi.list_namespaced_custom_object")
5161

5262
cluster = Cluster(
53-
ClusterConfiguration(name="default-appwrapper", namespace="ns", appwrapper=True, annotations={"app.kubernetes.io/managed-by": "test-prefix", "key1": "value1", "key2": "value2"})
63+
ClusterConfiguration(
64+
name="default-appwrapper",
65+
namespace="ns",
66+
appwrapper=True,
67+
annotations={
68+
"app.kubernetes.io/managed-by": "test-prefix",
69+
"key1": "value1",
70+
"key2": "value2",
71+
},
72+
)
5473
)
5574

5675
expected_aw = apply_template(

0 commit comments

Comments
 (0)
Please sign in to comment.