Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please avoid making pointless dependency updates #3481

Open
hannob opened this issue Jan 13, 2021 · 2 comments
Open

Please avoid making pointless dependency updates #3481

hannob opened this issue Jan 13, 2021 · 2 comments

Comments

@hannob
Copy link

hannob commented Jan 13, 2021

Is your feature request related to a problem? Please describe.

I'm maintaining ejabberd for a linux distribution (Gentoo). A lot of work is caused by the fact that ejabberd has a large number of dependencies that need regular updates.

However many of these dependencies seem to get new versions that don't change anything, and then dependencies get raised without any need.

To give an example: ejabberd 20.07 requires cache_tabl 1.0.25, while ejabberd 20.12 raised that to cache_tab 1.0.26. Looking at the git commit log https://github.com/processone/cache_tab/commits/master it seems nothing changed in the code between 1.0.25 and 1.0.26. The only changes are an updated changelog and changes to the travis ci config file. The update from 1.0.24 to 1.0.25 didn't change anything at all.

This seems to be a very regular pattern in your dependencies. There are updates without any actual changes, often just creating changelog entries or updating CI configs. None of that should justify raising a dependency.

Describe the solution you'd like
Please only make new releases of packages if there's actually some fixes or new features. And only raise dependencies if the new version is actually required.

@prefiks
Copy link
Member

prefiks commented Jan 13, 2021

Hello,

Yes it's a pain on our side too, but it's done for a reason, rebar that is used for builds doesn't have fuzzy/semver matching of version numbers, and there can be a problem with transient dependences, when different versions of same package is used, it doesn't always choose newest version in that case (it pick whichever did happen as first in dependency graph).

@mremond
Copy link
Member

mremond commented Apr 15, 2021

We have two options here:

  1. Moving the build chain to rebar3.
  2. Moving the build chain to mix.

I would rather use mix to also promote deeper integration with Elixir.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants