Updates requiring a reboot give the false impression that they failed (in the updates tab)

[processing-bot]

Created by: SableRaf

Description

Updating contributions that require a reboot from the updates tab makes it look like the update silently failed (especially when successful update just disappear from the list). It doesn't show the message "Please restart Processing to update this item" making it look like the update failed. The message can be seen when opening the modes tab and selecting the mode in question.

Expected Behavior

Give the user some indication that they need to reboot.

Current Behavior

No indications that the download succeeded, or that the update requires a reboot of Processing, are given.

Steps to Reproduce

1. Open PDE
2. Click on "Updates" at the bottom-right. This assumes there are updates available and that some of them require a reboot (Processing for Android going from 4.5.0b2 to 4.5.0b4 in my case)
3. Click Update All
4. Select the mode that was just updated.

Your Environment

• Processing version: 4.1.2
• Operating System and OS version: Windows 10

Screenshot

[processing-bot]

Created by: benfry

Is this a new problem in 4.x, or just something you're noticing now since there's no status area in the Updates tab?

[processing-bot]

Created by: benfry

Need more details here:

• With any luck, it should update without needing a restart. Does it not work?
• Is that screenshot with Android Mode still listed what it looks like after clicking “Update All” and letting it install?
• Are there any errors in the Console of the Editor window?

I'm working on this part of the code quite a bit at the moment, so I want to make sure we can fix it asap.

[processing-bot]

Created by: SableRaf

Hi @benfry and thanks for looking into this.

Is this a new problem in 4.x, or just something you're noticing now since there's no status area in the Updates tab?

I just noticed it now but it may have been the way things have always been. I just don't know.

With any luck, it should update without needing a restart. Does it not work?

I'm unable to check this, now that I have restarted. Either way, the issue is mostly one of UX since the current flow makes it look like the action has failed.

Is that screenshot with Android Mode still listed what it looks like after clicking “Update All” and letting it install?

Correct! I didn't take a screenshot of the Modes tab but it was saying "Please restart Processing to update this item".

Are there any errors in the Console of the Editor window?

I don't remember seeing any but I'm unable to test this as I have since rebooted Processing.

If you have suggestions on how I may be able to simulate the situation of updating from an old version of the Android mode to the latest, I'll be happy to run more tests.

[processing-bot]

Created by: SableRaf

Weird update: I just launched Processing to look at the Modes Manager again and the Android Mode was NOT installed anymore. I don't recall uninstalling it after posting this issue.

[processing-bot]

Created by: benfry

Can you make a copy of your sketchbook before fixing the problem?

Once you've done that, check the modes folder in your sketchbook… Is there an AndroidMode folder? And is there a version that was renamed/replaced in the old subfolder (check the date to see if it coincides with when you tried to install it most recently… there may be others).

[processing-bot]

Created by: SableRaf

I'm afraid I already installed it again. But now on reboot I get this message. I'll leave it be for now (gotta go live on Twitch). I'll be able to look into it again tomorrow.

[processing-bot]

Created by: SableRaf

This is what the modes/old folder looks like

[processing-bot]

Created by: benfry

Part of the weirdness here is that used to be necessary to require a restart of Processing (with Modes and Tools)… Then code was added so that you don't have to restart. Except… when it does, because something failed along the way: processing/processing#2705

So in releases since August 2014, a restart hasn't been required in most/many cases, even though the UI (sometimes) said it was.

But I'm wondering if we need to rip some of that back out—it's too flaky and makes the code a complete mess for tracking down issues like this. Requiring users to close and restart Processing (for Mode and Tool updates) doesn't seem as bad as the really odd behavior when things go wrong.

Especially if there's a “Restart Processing” button that can automatically quitting and restarting.