Skip to content

Screen reader says the wrong count in Preferences modal due to missing radiogroup #2648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lindapaiste opened this issue Nov 28, 2023 · 2 comments
Assignees
Labels
Area:Accessibility Category for accessibility related features and bugs Enhancement Priority:High

Comments

@lindapaiste
Copy link
Collaborator

Increasing Access

We want the editor to be fully navigable using screen readers.

Feature enhancement details

I downloaded a screenreader and I'm playing around and finding issues. In the preferences modal it announces like this:

"Autosave on checked radio button 4 of 11"

It should be announcing "1 of 2" instead of "4 of 11" (where 1 is "on" and 2 is "off"). But it uses the total count of the radio buttons in the form because we do not have the radiogroup attribute around each "on/off" section.

Might make sense to address this after #2323 so that we only need to change it in one (or two) places instead of many.

Resources:
https://www.w3.org/WAI/ARIA/apg/patterns/radio/examples/radio/
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/radiogroup_role

@lindapaiste lindapaiste added Area:Accessibility Category for accessibility related features and bugs Enhancement labels Nov 28, 2023
@lindapaiste lindapaiste self-assigned this Nov 28, 2023
@KrishavRajSingh
Copy link

is this open?

@Jatin24062005
Copy link
Contributor

@lindapaiste I looked into this issue on both Windows and macOS using the NVDA screen reader (as mentioned in the original report), and I couldn't reproduce the problem. The screen reader correctly announces "1 of 2" and "2 of 2" for the on/off radio buttons in the preferences modal.

For further confirmation, you can also check out the testing video I recorded.
@raclim — I believe this issue has been resolved and it's safe to close it now.

WhatsApp.Video.2025-04-20.at.18.36.57.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:Accessibility Category for accessibility related features and bugs Enhancement Priority:High
Projects
None yet
Development

No branches or pull requests

4 participants