feat: Support Probot v13 (#128)

BREAKING CHANGE: drop support for no longer maintained Node.js versions (14 and 16). Node 18+ is required now

Author: Oatelaus

.github/workflows/test.yml

@@ -12,9 +12,8 @@ jobs:
     strategy:
       matrix:
         node_version:
-          - 14
-          - 16
           - 18
+          - 20
     steps:
       - uses: actions/checkout@v3
       - name: Use Node.js ${{ matrix.node_version }}

package-lock.json

@@ -14,15 +14,14 @@
   },
   "repository": "github:probot/adapter-aws-lambda-serverless",
   "dependencies": {
-    "@probot/get-private-key": "^1.1.0",
     "@types/aws-lambda": "^8.10.85",
-    "probot": "^12.1.1",
-    "lowercase-keys": "^2.0.0"
+    "lowercase-keys": "^2.0.0",
+    "probot": "^13.3.0"
   },
   "devDependencies": {
     "@types/jest": "^29.0.0",
     "jest": "^29.0.0",
-    "nock": "^13.2.0",
+    "fetch-mock": "^10.0.5",
     "prettier": "^2.4.1"
   },
   "keywords": [

package.json

@@ -1,11 +1,9 @@
-const nock = require("nock");
 const path = require("path");
+const fetchMock = require("fetch-mock");
 
 const { createLambdaFunction, Probot, ProbotOctokit } = require("../index");
 const app = require("./fixtures/app");
 
-nock.disableNetConnect();
-
 describe("@probot/adapter-aws-lambda-serverless", () => {
   let probot;
 
@@ -21,21 +19,22 @@ describe("@probot/adapter-aws-lambda-serverless", () => {
     });
   });
 
+  afterEach(() => {
+    fetchMock.restore();
+  });
+
   test("happy path", async () => {
     const fn = createLambdaFunction(app, { probot });
 
-    const mock = nock("https://api.github.com")
-      .post(
-        "/repos/probot/adapter-adapter-aws-lambda-serverless/commits/headcommitsha123/comments",
-        (requestBody) => {
-          expect(requestBody).toStrictEqual({
-            body: `Hello from test${path.sep}fixtures${path.sep}app.js`,
-          });
-
-          return true;
-        }
-      )
-      .reply(201, {});
+    const mock = fetchMock.postOnce(
+      {
+        url: "https://api.github.com/repos/probot/adapter-adapter-aws-lambda-serverless/commits/headcommitsha123/comments",
+      },
+      {
+        body: {},
+        status: 201,
+      }
+    );
 
     const context = {};
     const payload = JSON.stringify(require("./fixtures/push.json"));
@@ -51,24 +50,28 @@ describe("@probot/adapter-aws-lambda-serverless", () => {
 
     await fn(event, context);
 
-    expect(mock.activeMocks()).toStrictEqual([]);
+    expect(
+      mock.called((_url, options) => {
+        return (
+          JSON.parse(options.body).body ===
+          `Hello from test${path.sep}fixtures${path.sep}app.js`
+        );
+      })
+    ).toBe(true);
   });
 
   test("lowercase request headers", async () => {
     const fn = createLambdaFunction(app, { probot });
 
-    const mock = nock("https://api.github.com")
-      .post(
-        "/repos/probot/adapter-adapter-aws-lambda-serverless/commits/headcommitsha123/comments",
-        (requestBody) => {
-          expect(requestBody).toStrictEqual({
-            body: `Hello from test${path.sep}fixtures${path.sep}app.js`,
-          });
-
-          return true;
-        }
-      )
-      .reply(201, {});
+    const mock = fetchMock.postOnce(
+      {
+        url: "https://api.github.com/repos/probot/adapter-adapter-aws-lambda-serverless/commits/headcommitsha123/comments",
+      },
+      {
+        body: {},
+        status: 201,
+      }
+    );
 
     const context = {};
     const payload = JSON.stringify(require("./fixtures/push.json"));
@@ -84,24 +87,28 @@ describe("@probot/adapter-aws-lambda-serverless", () => {
 
     await fn(event, context);
 
-    expect(mock.activeMocks()).toStrictEqual([]);
+    expect(
+      mock.called((_url, options) => {
+        return (
+          JSON.parse(options.body).body ===
+          `Hello from test${path.sep}fixtures${path.sep}app.js`
+        );
+      })
+    ).toBe(true);
   });
 
   test("GitHub request headers", async () => {
     const fn = createLambdaFunction(app, { probot });
 
-    const mock = nock("https://api.github.com")
-      .post(
-        "/repos/probot/adapter-adapter-aws-lambda-serverless/commits/headcommitsha123/comments",
-        (requestBody) => {
-          expect(requestBody).toStrictEqual({
-            body: `Hello from test${path.sep}fixtures${path.sep}app.js`,
-          });
-
-          return true;
-        }
-      )
-      .reply(201, {});
+    const mock = fetchMock.postOnce(
+      {
+        url: "https://api.github.com/repos/probot/adapter-adapter-aws-lambda-serverless/commits/headcommitsha123/comments",
+      },
+      {
+        body: {},
+        status: 201,
+      }
+    );
 
     const context = {};
     const payload = JSON.stringify(require("./fixtures/push.json"));
@@ -117,24 +124,28 @@ describe("@probot/adapter-aws-lambda-serverless", () => {
 
     await fn(event, context);
 
-    expect(mock.activeMocks()).toStrictEqual([]);
+    expect(
+      mock.called((_url, options) => {
+        return (
+          JSON.parse(options.body).body ===
+          `Hello from test${path.sep}fixtures${path.sep}app.js`
+        );
+      })
+    ).toBe(true);
   });
 
   test("camelcase request headers (#62)", async () => {
     const fn = createLambdaFunction(app, { probot });
 
-    const mock = nock("https://api.github.com")
-      .post(
-        "/repos/probot/adapter-adapter-aws-lambda-serverless/commits/headcommitsha123/comments",
-        (requestBody) => {
-          expect(requestBody).toStrictEqual({
-            body: `Hello from test${path.sep}fixtures${path.sep}app.js`,
-          });
-
-          return true;
-        }
-      )
-      .reply(201, {});
+    const mock = fetchMock.postOnce(
+      {
+        url: "https://api.github.com/repos/probot/adapter-adapter-aws-lambda-serverless/commits/headcommitsha123/comments",
+      },
+      {
+        body: {},
+        status: 201,
+      }
+    );
 
     const context = {};
     const payload = JSON.stringify(require("./fixtures/push.json"));
@@ -150,6 +161,13 @@ describe("@probot/adapter-aws-lambda-serverless", () => {
 
     await fn(event, context);
 
-    expect(mock.activeMocks()).toStrictEqual([]);
+    expect(
+      mock.called((_url, options) => {
+        return (
+          JSON.parse(options.body).body ===
+          `Hello from test${path.sep}fixtures${path.sep}app.js`
+        );
+      })
+    ).toBe(true);
   });
 });