[FBref] Add support for scraping detailed player information

[baniasbaabe]

Retrieving more information about a specific player like club history would be nice!

[babu-akhil]

I'd be willing to work on this.

@probberechts On the implementation for this, I am thinking to implement a function like fbref.read_player_club_history(player_id) with using player_id like '507c7bdf' (https://fbref.com/en/players/507c7bdf/ links to Bruno Fernandes). Would this be a good approach?

Or do you think it is better to have more abstractions like fbref_player classes which can then have multiple functions for scraping for the various information on the player page , none of which are supported right now.

[probberechts]

The issue here is that the FBref class should be initialized with a league and season. All functions in that class than only return data for the given league and season. This is not desirable when you scrape a player's club history. Therefore, I think a better solution would be to add a FBrefPlayer class.

[babu-akhil]

I was trying to work on this -

but the tests are failing on my fork without any changes

======================================================================================== short test summary info =========================================================================================
FAILED tests/test_FiveThirtyEight.py::test_read_leagues - json.decoder.JSONDecodeError: Expecting value: line 2 column 9 (char 9)
FAILED tests/test_FiveThirtyEight.py::test_read_games - json.decoder.JSONDecodeError: Expecting value: line 2 column 9 (char 9)
FAILED tests/test_FiveThirtyEight.py::test_read_forecasts - json.decoder.JSONDecodeError: Expecting value: line 2 column 9 (char 9)
FAILED tests/test_FiveThirtyEight.py::test_read_clinches - json.decoder.JSONDecodeError: Expecting value: line 2 column 9 (char 9)
FAILED tests/test_FiveThirtyEight.py::test_filter_leagues - json.decoder.JSONDecodeError: Expecting value: line 2 column 9 (char 9)
FAILED tests/test_SoFIFA.py::test_read_team_ratings - IndexError: list index out of range