Only run replaceChildren with htmlContainer change (#2356)

* Only run replaceChildren with htmlContainer change

* Create weak-hotels-shout.md

Co-authored-by: Cole Bemis <[email protected]>

Author: nicolleromero

.changeset/weak-hotels-shout.md

@@ -0,0 +1,5 @@
+---
+"@primer/react": patch
+---
+
+MarkdownViewer bug fix: Only run `replaceChildren` when `htmlContainer` changes

src/drafts/MarkdownViewer/MarkdownViewer.tsx

@@ -107,7 +107,7 @@ const MarkdownViewer = ({
   // If we were to inject the `...htmlContainer.children` instead of the container element itself,
   // those children elements would be moved from the `htmlContainer` to the `outputContainer`. Then if
   // other effects use `htmlContainer.querySelectorAll`, they wouldn't find any elements to affect
-  useEffect(() => outputContainerRef.current?.replaceChildren(htmlContainer))
+  useEffect(() => outputContainerRef.current?.replaceChildren(htmlContainer), [htmlContainer])
 
   return loading ? (
     <Box sx={{display: 'flex', justifyContent: 'space-around', p: 2}}>