Skip to content

Commit e90daf3

Browse files
atscottkirjs
authored andcommitted
refactor(core): Update Transition finished promise to not throw unhandled rejection (angular#60816)
As with `InternalNavigationResult`, this commit adds the `catch` to the `finished` promise on `InternalNavigationTransition` to avoid unhandled promise rejections. PR Close angular#60816
1 parent 388c749 commit e90daf3

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

packages/core/primitives/dom-navigation/testing/fake_navigation.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1145,6 +1145,8 @@ class InternalNavigationTransition implements NavigationTransition {
11451145
this.finishedReject = reject;
11461146
this.finishedResolve = resolve;
11471147
});
1148+
// All rejections are handled.
1149+
this.finished.catch(() => {});
11481150
}
11491151
}
11501152

0 commit comments

Comments
 (0)