Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] Release to add ppc64le support #17

Open
amitsadaphule opened this issue Oct 13, 2020 · 9 comments
Open

[question] Release to add ppc64le support #17

amitsadaphule opened this issue Oct 13, 2020 · 9 comments

Comments

@amitsadaphule
Copy link
Contributor

amitsadaphule commented Oct 13, 2020

With the merge of #13 which resolves #12, ppc64le support is enabled in master branch. I'd like to request for info on the ETA for next release (including upload of jars to maven central). I'll raise PRs on the prestodb/presto repo once this release is available.

I have same question for https://github.com/prestodb/testing-postgresql-server repo since the PR prestodb/testing-postgresql-server#3 has been merged. I could not raise the issue/question there, since the issues tab is disabled there.

@rschlussel do you have any updates on the plan to upload the jars to maven central?

@amitsadaphule
Copy link
Contributor Author

Cc @gerrith3 @seth-priya

@amitsadaphule
Copy link
Contributor Author

@rschlussel do you have any information on this? Or can you maybe point me to someone who handles the releases for these repos?

@rschlussel
Copy link
Contributor

I'm very sorry. I lost track of this issue. Let me do the release now.

@rschlussel
Copy link
Contributor

I can't release because the directories below (e.g. usr/bin/mysqldb) do not exist for me when I build locally on my mac. Is there a way to make this more general?

cp usr/bin/mysql_install_db mysql-Linux-ppc64le/bin/
cp usr/bin/my_print_defaults mysql-Linux-ppc64le/bin/
cp usr/bin/resolveip mysql-Linux-ppc64le/bin/
cp usr/sbin/mysqld mysql-Linux-ppc64le/bin/
cp -r usr/lib64/* mysql-Linux-ppc64le/lib64/
cp -r usr/share/mysql mysql-Linux-ppc64le/share/

@amitsadaphule
Copy link
Contributor Author

That's odd. Can you please check if there were any errors returned by this line (i.e. rpm2cpio or cpio command)?

@rschlussel
Copy link
Contributor

You're right:

+ cpio -idm
/Users/rschlussel/testing-mysql-server/testing-mysql-server-5/repack-mysql-5.sh: line 73: rpm2cpio: command not found
0 blocks

We should make sure that throws an error.

@rschlussel
Copy link
Contributor

got around that issue by installing rpm2cpio. Then encountered another issue that turns out was caused by the url for the mariadb rpm not existing anymore (so didn't download a proper rpm). Have a fix here to update to a more recent version #18.

@rschlussel
Copy link
Contributor

rschlussel commented Dec 29, 2020

Created the release in github, but haven't uploaded the artifacts to nexus yet because to do that I need to update the system we use to deploy them, and we have a freeze this week on making any changes. I'll do it right after the new year.

@amitsadaphule
Copy link
Contributor Author

Thanks @rschlussel! Can you please also create the release for https://github.com/prestodb/testing-postgresql-server. I couldn't add an issue there, since the issues tab is not accessible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants