From 5e110d97dd3e3e43cdc9a258c206600481798852 Mon Sep 17 00:00:00 2001
From: Chandrashekhar Kumar Singh <shekharsingh@meta.com>
Date: Mon, 7 Oct 2024 11:05:24 -0700
Subject: [PATCH] Add build param to skip creating hardlinks

Presto build fails when a filesystem with no support for hardlinks is used. Add new param to specify hardlink include jars.
---
 README.md                                  | 4 ++++
 pom.xml                                    | 1 +
 presto-server/pom.xml                      | 1 +
 presto-server/src/main/provisio/presto.xml | 2 +-
 4 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/README.md b/README.md
index 20fcc4ca4a2ed..ff92c6c636fed 100644
--- a/README.md
+++ b/README.md
@@ -33,6 +33,10 @@ Presto has a comprehensive set of unit tests that can take several minutes to ru
 
     ./mvnw clean install -DskipTests
 
+Presto uses the [Provisio](https://github.com/jvanzyl/provisio) plugin for packaging using hard links. If your filesystem doesn't support hard links, you can bypass hard links using:
+    
+    ./mvnw clean install -presto.hard-link-includes=''
+
 After building Presto for the first time, you can load the project into your IDE and run the server. We recommend using [IntelliJ IDEA](http://www.jetbrains.com/idea/). Because Presto is a standard Maven project, you can import it into your IDE using the root `pom.xml` file. In IntelliJ, choose Open Project from the Quick Start box or choose Open from the File menu and select the root `pom.xml` file.
 
 After opening the project in IntelliJ, double check that the Java SDK is properly configured for the project:
diff --git a/pom.xml b/pom.xml
index 5b0c7d82b6aad..d4806eb46234c 100644
--- a/pom.xml
+++ b/pom.xml
@@ -95,6 +95,7 @@
         <grpc.version>1.64.0</grpc.version>
 
         <air.javadoc.lint>-missing</air.javadoc.lint>
+        <presto.hard-link-includes>**/*.jar</presto.hard-link-includes>
     </properties>
 
     <modules>
diff --git a/presto-server/pom.xml b/presto-server/pom.xml
index deeff2d162f34..3667cacb6a661 100644
--- a/presto-server/pom.xml
+++ b/presto-server/pom.xml
@@ -25,6 +25,7 @@
         <process-name>${project.artifactId}</process-name>
 
         <skipTakariLifecyclePlugin>false</skipTakariLifecyclePlugin>
+        <presto.hard-link-includes>${project.parent.presto.hard-link-includes}</presto.hard-link-includes>
     </properties>
 
     <build>
diff --git a/presto-server/src/main/provisio/presto.xml b/presto-server/src/main/provisio/presto.xml
index 4e82ac23b9a1f..1b7c579c72e2a 100644
--- a/presto-server/src/main/provisio/presto.xml
+++ b/presto-server/src/main/provisio/presto.xml
@@ -1,6 +1,6 @@
 <runtime>
     <!-- Target -->
-    <archive name="${project.artifactId}-${project.version}.tar.gz" hardLinkIncludes="**/*.jar" />
+    <archive name="${project.artifactId}-${project.version}.tar.gz" hardLinkIncludes="${presto.hard-link-includes}" />
 
     <!-- Notices -->
     <fileSet to="/">