Skip to content

Commit 596d90d

Browse files
committed
[ToBeSquashed]Ignore tests and fix document
1 parent f08edd5 commit 596d90d

File tree

4 files changed

+9
-6
lines changed

4 files changed

+9
-6
lines changed

presto-docs/src/main/sphinx/connector/iceberg.rst

+5-4
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ Property Name Description
263263
``iceberg.catalog.hadoop.warehouse.datadir`` The catalog warehouse root data path for Iceberg tables.
264264
Example: ``s3://iceberg_bucket/warehouse``.
265265
This property is only supported with Hadoop catalog. If set,
266-
all tables in this Hadoop catalog will default to saving
266+
all tables in this Hadoop catalog default to saving
267267
their data and delete files in the specified root
268268
data directory.
269269

@@ -275,9 +275,10 @@ Property Name Description
275275
.. note::
276276

277277
Hadoop catalog requires a file system that supports atomic rename operation, such as HDFS,
278-
to maintain metadata files in order to implement atomic transaction commit. It's unsafe to
279-
set `iceberg.catalog.warehouse` to a path in object stores and local file systems. But it's
280-
safe to set `iceberg.catalog.hadoop.warehouse.datadir` to a path in the object stores.
278+
to maintain metadata files in order to implement atomic transaction commit. Do not set
279+
`iceberg.catalog.warehouse` to a path in object stores and local file systems in the
280+
production environment. But it's safe to set `iceberg.catalog.hadoop.warehouse.datadir`
281+
to a path in the object stores.
281282

282283
Configure the `Amazon S3 <https://prestodb.io/docs/current/connector/hive.html#amazon-s3-configuration>`_
283284
properties to specify a S3 location as the warehouse data directory for the Hadoop catalog. This way,

presto-iceberg/src/test/java/com/facebook/presto/iceberg/hadoop/TestIcebergDistributedHadoop.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
import static java.lang.String.format;
2424
import static java.nio.file.Files.createTempDirectory;
2525

26-
@Test
26+
@Test(enabled = false)
2727
public class TestIcebergDistributedHadoop
2828
extends IcebergDistributedTestBase
2929
{

presto-iceberg/src/test/java/com/facebook/presto/iceberg/hadoop/TestIcebergHadoopCatalogDistributedQueries.java

+2
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,11 @@
1414
package com.facebook.presto.iceberg.hadoop;
1515

1616
import com.facebook.presto.iceberg.TestIcebergDistributedQueries;
17+
import org.testng.annotations.Test;
1718

1819
import static com.facebook.presto.iceberg.CatalogType.HADOOP;
1920

21+
@Test(enabled = false)
2022
public class TestIcebergHadoopCatalogDistributedQueries
2123
extends TestIcebergDistributedQueries
2224
{

presto-iceberg/src/test/java/com/facebook/presto/iceberg/hadoop/TestIcebergSmokeHadoop.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
import static java.lang.String.format;
3838
import static org.assertj.core.api.Assertions.assertThat;
3939

40-
@Test
40+
@Test(enabled = false)
4141
public class TestIcebergSmokeHadoop
4242
extends IcebergDistributedSmokeTestBase
4343
{

0 commit comments

Comments
 (0)