Skip to content

Commit 6959e94

Browse files
andrewigginsandrewiggins
authored
Remove prettier override so editorconfig is applied (#360)
We had useTabs: true in our prettier config which overrode our .editorconfig to use spaces in json files. I've removed the useTabs in the package.json prettier config so .editorconfig is used instead. I've also reformatted all the code so it's consistent.
1 parent 7973248 commit 6959e94

File tree

15 files changed

+320
-332
lines changed

15 files changed

+320
-332
lines changed

‎.changeset/config.json

+9-9
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
{
2-
"$schema": "https://unpkg.com/@changesets/[email protected]/schema.json",
3-
"changelog": ["@changesets/changelog-github", { "repo": "preactjs/signals" }],
4-
"commit": false,
5-
"fixed": [],
6-
"linked": [],
7-
"access": "public",
8-
"baseBranch": "main",
9-
"updateInternalDependencies": "patch",
10-
"ignore": []
2+
"$schema": "https://unpkg.com/@changesets/[email protected]/schema.json",
3+
"changelog": ["@changesets/changelog-github", { "repo": "preactjs/signals" }],
4+
"commit": false,
5+
"fixed": [],
6+
"linked": [],
7+
"access": "public",
8+
"baseBranch": "main",
9+
"updateInternalDependencies": "patch",
10+
"ignore": []
1111
}

‎.devcontainer/devcontainer.json

+15-15
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
{
2-
"name": "preact/signals",
3-
"build": {
4-
"dockerfile": "Dockerfile"
5-
},
6-
"customizations": {
7-
"vscode": {
8-
"settings": {
9-
"editor.defaultFormatter": "esbenp.prettier-vscode",
10-
"explorer.excludeGitIgnore": true
11-
},
12-
"extensions": ["dbaeumer.vscode-eslint", "esbenp.prettier-vscode"]
13-
}
14-
},
15-
"postCreateCommand": "pnpm i",
16-
"remoteUser": "node"
2+
"name": "preact/signals",
3+
"build": {
4+
"dockerfile": "Dockerfile"
5+
},
6+
"customizations": {
7+
"vscode": {
8+
"settings": {
9+
"editor.defaultFormatter": "esbenp.prettier-vscode",
10+
"explorer.excludeGitIgnore": true
11+
},
12+
"extensions": ["dbaeumer.vscode-eslint", "esbenp.prettier-vscode"]
13+
}
14+
},
15+
"postCreateCommand": "pnpm i",
16+
"remoteUser": "node"
1717
}

‎.github/workflows/compressed-size.yml

+2-3
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ jobs:
1919
- name: compressed-size-action
2020
uses: preactjs/compressed-size-action@v2
2121
with:
22-
pattern: '{packages/*/dist/!(*.module|*.min).{js,mjs},docs/dist/**/*.{js,css}}'
23-
build-script: 'ci:build'
22+
pattern: "{packages/*/dist/!(*.module|*.min).{js,mjs},docs/dist/**/*.{js,css}}"
23+
build-script: "ci:build"
2424
strip-hash: "[.-](\\w{8,9})\\.(?:js|css)$"
25-

‎README.md

+9-10
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
21
# Signals
32

43
Signals is a performant state management library with two primary goals:
@@ -22,17 +21,17 @@ npm install @preact/signals-core
2221
```
2322

2423
- [Guide / API](#guide--api)
25-
- [`signal(initialValue)`](#signalinitialvalue)
26-
- [`signal.peek()`](#signalpeek)
27-
- [`computed(fn)`](#computedfn)
28-
- [`effect(fn)`](#effectfn)
29-
- [`batch(fn)`](#batchfn)
24+
- [`signal(initialValue)`](#signalinitialvalue)
25+
- [`signal.peek()`](#signalpeek)
26+
- [`computed(fn)`](#computedfn)
27+
- [`effect(fn)`](#effectfn)
28+
- [`batch(fn)`](#batchfn)
3029
- [Preact Integration](./packages/preact/README.md#preact-integration)
31-
- [Hooks](./packages/preact/README.md#hooks)
32-
- [Rendering optimizations](./packages/preact/README.md#rendering-optimizations)
33-
- [Attribute optimization (experimental)](./packages/preact/README.md#attribute-optimization-experimental)
30+
- [Hooks](./packages/preact/README.md#hooks)
31+
- [Rendering optimizations](./packages/preact/README.md#rendering-optimizations)
32+
- [Attribute optimization (experimental)](./packages/preact/README.md#attribute-optimization-experimental)
3433
- [React Integration](./packages/react/README.md#react-integration)
35-
- [Hooks](./packages/react/README.md#hooks)
34+
- [Hooks](./packages/react/README.md#hooks)
3635
- [License](#license)
3736

3837
## Guide / API

‎docs/demos/react/tsconfig.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"extends": "../../tsconfig.json",
33
"compilerOptions": {
4-
"jsxImportSource": "react",
4+
"jsxImportSource": "react"
55
}
66
}

‎docs/package.json

+32-32
Original file line numberDiff line numberDiff line change
@@ -1,34 +1,34 @@
11
{
2-
"name": "demo",
3-
"private": true,
4-
"scripts": {
5-
"start": "vite",
6-
"build": "vite build",
7-
"preview": "vite preview"
8-
},
9-
"postcss": {
10-
"plugins": {
11-
"postcss-nesting": {}
12-
}
13-
},
14-
"dependencies": {
15-
"preact": "10.9.0",
16-
"preact-iso": "^2.3.0",
17-
"preact-render-to-string": "^5.2.1",
18-
"@preact/signals-core": "workspace:../packages/core",
19-
"@preact/signals": "workspace:../packages/preact",
20-
"@preact/signals-react": "workspace:../packages/react",
21-
"react": "^18.2.0",
22-
"react-dom": "^18.2.0"
23-
},
24-
"devDependencies": {
25-
"@babel/core": "^7.18.10",
26-
"@preact/preset-vite": "^2.3.0",
27-
"@types/react": "^18.0.18",
28-
"@types/react-dom": "^18.0.6",
29-
"postcss": "^8.4.16",
30-
"postcss-nesting": "^10.1.10",
31-
"tiny-glob": "^0.2.9",
32-
"vite": "^3.0.7"
33-
}
2+
"name": "demo",
3+
"private": true,
4+
"scripts": {
5+
"start": "vite",
6+
"build": "vite build",
7+
"preview": "vite preview"
8+
},
9+
"postcss": {
10+
"plugins": {
11+
"postcss-nesting": {}
12+
}
13+
},
14+
"dependencies": {
15+
"preact": "10.9.0",
16+
"preact-iso": "^2.3.0",
17+
"preact-render-to-string": "^5.2.1",
18+
"@preact/signals-core": "workspace:../packages/core",
19+
"@preact/signals": "workspace:../packages/preact",
20+
"@preact/signals-react": "workspace:../packages/react",
21+
"react": "^18.2.0",
22+
"react-dom": "^18.2.0"
23+
},
24+
"devDependencies": {
25+
"@babel/core": "^7.18.10",
26+
"@preact/preset-vite": "^2.3.0",
27+
"@types/react": "^18.0.18",
28+
"@types/react-dom": "^18.0.6",
29+
"postcss": "^8.4.16",
30+
"postcss-nesting": "^10.1.10",
31+
"tiny-glob": "^0.2.9",
32+
"vite": "^3.0.7"
33+
}
3434
}

‎mangle.json

+1-5
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,7 @@
55
},
66
"minify": {
77
"mangle": {
8-
"reserved": [
9-
"useSignal",
10-
"useComputed",
11-
"useSignalEffect"
12-
],
8+
"reserved": ["useSignal", "useComputed", "useSignalEffect"],
139
"keep_classnames": true,
1410
"properties": {
1511
"regex": "^_[^_]",

‎package.json

+97-97
Original file line numberDiff line numberDiff line change
@@ -1,99 +1,99 @@
11
{
2-
"name": "preact-signals",
3-
"private": true,
4-
"scripts": {
5-
"prebuild": "rimraf packages/core/dist/ packages/preact/dist",
6-
"build": "pnpm build:core && pnpm build:preact && pnpm build:react",
7-
"build:core": "microbundle --raw --cwd packages/core && pnpm postbuild:core",
8-
"build:preact": "microbundle --raw --cwd packages/preact && pnpm postbuild:preact",
9-
"build:react": "microbundle --raw --cwd packages/react && pnpm postbuild:react",
10-
"postbuild:core": "cd packages/core/dist && mv -f index.d.ts signals-core.d.ts",
11-
"postbuild:preact": "cd packages/preact/dist && mv -f preact/src/index.d.ts signals.d.ts && rm -dr preact",
12-
"postbuild:react": "cd packages/react/dist && mv -f react/src/index.d.ts signals.d.ts && rm -dr react",
13-
"postbuild": "node ./scripts/node-13-exports.js",
14-
"lint": "eslint 'packages/**/*.{ts,tsx,js,jsx}'",
15-
"test": "pnpm test:karma && pnpm test:mocha",
16-
"test:minify": "pnpm test:karma:minify && pnpm test:mocha",
17-
"test:prod": "pnpm test:karma:prod && pnpm test:mocha:prod",
18-
"test:karma": "cross-env COVERAGE=true karma start karma.conf.js --single-run",
19-
"test:karma:minify": "cross-env COVERAGE=true MINIFY=true karma start karma.conf.js --single-run",
20-
"test:karma:watch": "karma start karma.conf.js --no-single-run",
21-
"test:karma:prod": "cross-env MINIFY=true NODE_ENV=production karma start karma.conf.js --single-run",
22-
"test:karma:prod:watch": "cross-env NODE_ENV=production karma start karma.conf.js --no-single-run",
23-
"test:mocha": "cross-env COVERAGE=true mocha --require packages/react/test/node/setup.js --recursive packages/react/test/node/**.test.tsx",
24-
"test:mocha:prod": "cross-env COVERAGE=true NODE_ENV=production mocha --require packages/react/test/node/setup.js --recursive packages/react/test/node/**.test.tsx",
25-
"docs:start": "cd docs && pnpm start",
26-
"docs:build": "cd docs && pnpm build",
27-
"docs:preview": "cd docs && pnpm preview",
28-
"ci:build": "pnpm build && pnpm docs:build",
29-
"ci:test": "pnpm lint && pnpm test",
30-
"release": "pnpm changeset version && pnpm install && git add -A && git commit -m 'Version Packages' && changeset tag && pnpm publish -r"
31-
},
32-
"authors": [
33-
"The Preact Authors (https://github.com/preactjs/signals/contributors)"
34-
],
35-
"license": "MIT",
36-
"devDependencies": {
37-
"@babel/core": "^7.19.1",
38-
"@babel/plugin-transform-typescript": "^7.19.1",
39-
"@babel/preset-env": "^7.19.1",
40-
"@babel/preset-react": "^7.18.6",
41-
"@babel/preset-typescript": "^7.18.6",
42-
"@babel/register": "^7.21.0",
43-
"@changesets/changelog-github": "^0.4.6",
44-
"@changesets/cli": "^2.24.2",
45-
"@types/chai": "^4.3.3",
46-
"@types/mocha": "^9.1.1",
47-
"@types/node": "^18.6.5",
48-
"@types/sinon": "^10.0.13",
49-
"@types/sinon-chai": "^3.2.8",
50-
"@typescript-eslint/eslint-plugin": "^5.33.0",
51-
"@typescript-eslint/parser": "^5.33.0",
52-
"babel-plugin-istanbul": "^6.1.1",
53-
"babel-plugin-transform-rename-properties": "^0.1.0",
54-
"chai": "^4.3.6",
55-
"cross-env": "^7.0.3",
56-
"errorstacks": "^2.4.0",
57-
"esbuild": "^0.14.54",
58-
"eslint": "^8.21.0",
59-
"eslint-config-prettier": "^8.5.0",
60-
"husky": "^8.0.1",
61-
"karma": "6.3.16",
62-
"karma-chai-sinon": "^0.1.5",
63-
"karma-chrome-launcher": "^3.1.1",
64-
"karma-coverage": "^2.2.0",
65-
"karma-esbuild": "^2.2.5",
66-
"karma-mocha": "^2.0.1",
67-
"karma-mocha-reporter": "^2.2.5",
68-
"karma-sinon": "^1.0.5",
69-
"kolorist": "^1.5.1",
70-
"lint-staged": "^13.0.3",
71-
"microbundle": "^0.15.1",
72-
"mocha": "^10.0.0",
73-
"prettier": "^2.7.1",
74-
"rimraf": "^3.0.2",
75-
"sinon": "^14.0.0",
76-
"sinon-chai": "^3.7.0",
77-
"typescript": "^4.7.4"
78-
},
79-
"lint-staged": {
80-
"**/*.{js,jsx,ts,tsx,yml}": [
81-
"prettier --write"
82-
]
83-
},
84-
"husky": {
85-
"hooks": {
86-
"pre-commit": "lint-staged"
87-
}
88-
},
89-
"prettier": {
90-
"useTabs": true,
91-
"arrowParens": "avoid"
92-
},
93-
"pnpm": {
94-
"patchedDependencies": {
95-
"[email protected]": "patches/[email protected]",
96-
"@babel/[email protected]": "patches/@[email protected]"
97-
}
98-
}
2+
"name": "preact-signals",
3+
"private": true,
4+
"scripts": {
5+
"prebuild": "rimraf packages/core/dist/ packages/preact/dist",
6+
"build": "pnpm build:core && pnpm build:preact && pnpm build:react",
7+
"build:core": "microbundle --raw --cwd packages/core && pnpm postbuild:core",
8+
"build:preact": "microbundle --raw --cwd packages/preact && pnpm postbuild:preact",
9+
"build:react": "microbundle --raw --cwd packages/react && pnpm postbuild:react",
10+
"postbuild:core": "cd packages/core/dist && mv -f index.d.ts signals-core.d.ts",
11+
"postbuild:preact": "cd packages/preact/dist && mv -f preact/src/index.d.ts signals.d.ts && rm -dr preact",
12+
"postbuild:react": "cd packages/react/dist && mv -f react/src/index.d.ts signals.d.ts && rm -dr react",
13+
"postbuild": "node ./scripts/node-13-exports.js",
14+
"lint": "eslint 'packages/**/*.{ts,tsx,js,jsx}'",
15+
"test": "pnpm test:karma && pnpm test:mocha",
16+
"test:minify": "pnpm test:karma:minify && pnpm test:mocha",
17+
"test:prod": "pnpm test:karma:prod && pnpm test:mocha:prod",
18+
"test:karma": "cross-env COVERAGE=true karma start karma.conf.js --single-run",
19+
"test:karma:minify": "cross-env COVERAGE=true MINIFY=true karma start karma.conf.js --single-run",
20+
"test:karma:watch": "karma start karma.conf.js --no-single-run",
21+
"test:karma:prod": "cross-env MINIFY=true NODE_ENV=production karma start karma.conf.js --single-run",
22+
"test:karma:prod:watch": "cross-env NODE_ENV=production karma start karma.conf.js --no-single-run",
23+
"test:mocha": "cross-env COVERAGE=true mocha --require packages/react/test/node/setup.js --recursive packages/react/test/node/**.test.tsx",
24+
"test:mocha:prod": "cross-env COVERAGE=true NODE_ENV=production mocha --require packages/react/test/node/setup.js --recursive packages/react/test/node/**.test.tsx",
25+
"docs:start": "cd docs && pnpm start",
26+
"docs:build": "cd docs && pnpm build",
27+
"docs:preview": "cd docs && pnpm preview",
28+
"ci:build": "pnpm build && pnpm docs:build",
29+
"ci:test": "pnpm lint && pnpm test",
30+
"release": "pnpm changeset version && pnpm install && git add -A && git commit -m 'Version Packages' && changeset tag && pnpm publish -r",
31+
"format": "prettier --ignore-path .gitignore --write '**/*.{js,jsx,ts,tsx,yml,json,md}'"
32+
},
33+
"authors": [
34+
"The Preact Authors (https://github.com/preactjs/signals/contributors)"
35+
],
36+
"license": "MIT",
37+
"devDependencies": {
38+
"@babel/core": "^7.19.1",
39+
"@babel/plugin-transform-typescript": "^7.19.1",
40+
"@babel/preset-env": "^7.19.1",
41+
"@babel/preset-react": "^7.18.6",
42+
"@babel/preset-typescript": "^7.18.6",
43+
"@babel/register": "^7.21.0",
44+
"@changesets/changelog-github": "^0.4.6",
45+
"@changesets/cli": "^2.24.2",
46+
"@types/chai": "^4.3.3",
47+
"@types/mocha": "^9.1.1",
48+
"@types/node": "^18.6.5",
49+
"@types/sinon": "^10.0.13",
50+
"@types/sinon-chai": "^3.2.8",
51+
"@typescript-eslint/eslint-plugin": "^5.33.0",
52+
"@typescript-eslint/parser": "^5.33.0",
53+
"babel-plugin-istanbul": "^6.1.1",
54+
"babel-plugin-transform-rename-properties": "^0.1.0",
55+
"chai": "^4.3.6",
56+
"cross-env": "^7.0.3",
57+
"errorstacks": "^2.4.0",
58+
"esbuild": "^0.14.54",
59+
"eslint": "^8.21.0",
60+
"eslint-config-prettier": "^8.5.0",
61+
"husky": "^8.0.1",
62+
"karma": "6.3.16",
63+
"karma-chai-sinon": "^0.1.5",
64+
"karma-chrome-launcher": "^3.1.1",
65+
"karma-coverage": "^2.2.0",
66+
"karma-esbuild": "^2.2.5",
67+
"karma-mocha": "^2.0.1",
68+
"karma-mocha-reporter": "^2.2.5",
69+
"karma-sinon": "^1.0.5",
70+
"kolorist": "^1.5.1",
71+
"lint-staged": "^13.0.3",
72+
"microbundle": "^0.15.1",
73+
"mocha": "^10.0.0",
74+
"prettier": "^2.7.1",
75+
"rimraf": "^3.0.2",
76+
"sinon": "^14.0.0",
77+
"sinon-chai": "^3.7.0",
78+
"typescript": "^4.7.4"
79+
},
80+
"lint-staged": {
81+
"**/*.{js,jsx,ts,tsx,yml,json,md}": [
82+
"prettier --write"
83+
]
84+
},
85+
"husky": {
86+
"hooks": {
87+
"pre-commit": "lint-staged"
88+
}
89+
},
90+
"prettier": {
91+
"arrowParens": "avoid"
92+
},
93+
"pnpm": {
94+
"patchedDependencies": {
95+
"[email protected]": "patches/[email protected]",
96+
"@babel/[email protected]": "patches/@[email protected]"
97+
}
98+
}
9999
}

0 commit comments

Comments
 (0)