You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+8-9Lines changed: 8 additions & 9 deletions
Original file line number
Diff line number
Diff line change
@@ -2,13 +2,13 @@
2
2
3
3
Thank you for considering to contribute to rust-skia.
4
4
5
-
We welcome all contributions, but most likely, a large part of your contribution will be Rust code.
5
+
We welcome all contributions. Most likely, a large part of your contribution will be Rust code.
6
6
7
-
To contribute Rust code, format the code with `cargo fmt` and be sure that there are no warnings with `cargo clippy`. Don't try too hard follow Clippy suggestions. If a warning does not make sense, add a comment that explains why, and mark the code with a `#[allow(clippy::*)]` attribute.
7
+
To contribute Rust code, format the code with `cargo fmt` and be sure that there are no warnings with `cargo clippy`. Don't try too hard follow Clippy suggestions. If a warning does not make sense, add a comment that explains why and mark the code with a `#[allow(clippy::*)]` attribute.
8
8
9
9
If possible, add a small test case for you changes.
10
10
11
-
Your PR will be built for and tested on a number of targets on the CI before it can be merged. If that fails, we are probably able to help out.
11
+
Your PR will be built for and tested on a number of targets on the CI before it can be merged. If that fails, we will do our best to help out.
12
12
13
13
If you'd like the changes in your PR to be released to [crates.io](https://crates.io/) timely, please say so, because we prefer to align crate releases with major [updates to Chrome stable](https://chromestatus.com/roadmap).
14
14
@@ -23,21 +23,20 @@ We did our best to cover most of the Skia API, but you'll find a lot of blind sp
23
23
- GPU API support is incomplete, specifically functions that use callbacks.
24
24
- Supporting [Skottie](https://skia.org/user/modules/skottie) would be a nice addition.
25
25
26
-
For larger contributions, make yourself familiar with the [various wrapper types](https://github.com/rust-skia/rust-skia/wiki)of skia-safe and consider to file an issue beforehand to give us a heads up and to receive additional directions.
26
+
For larger contributions, familiarize yourself with the [various wrapper types](https://github.com/rust-skia/rust-skia/wiki) and consider filing an issue beforehand to give us a heads up and to receive additional directions.
27
27
28
28
## Contributing Examples
29
29
30
-
Examples should be added to `/skia-safe/examples` or directly to the `/skia-org` executable which provides a minimal infrastructure to render to PNG, PDF, SVG files with the CPU or GPU.
30
+
Examples should be added to `/skia-safe/examples` or directly to the `/skia-org` executable which provides a minimal infrastructure to render to PNG, PDF, and SVG files using the CPU or the GPU.
31
31
32
32
## Updating Skia
33
33
34
-
Since the beginning of this project, the maintainer team is updating rust-skia to match the Skia API version in the latest stable Chrome release. A new Chrome release [is scheduled](https://chromium.googlesource.com/chromium/src/+/master/docs/process/release_cycle.md) about every 6 weeks and most changes for the upcoming version are already settled when the current release is out, so there is enough time to update rust-skia. For most new Skia releases, the changes are trivial and can be integrated without breaking backwards compatibility on the Rust side.
34
+
Since the beginning of this project, the maintainer team is updating rust-skia to match the Skia API version in the latest stable Chrome release. A new Chrome release [is scheduled](https://chromium.googlesource.com/chromium/src/+/master/docs/process/release_cycle.md) about every 4 weeks and most changes for the upcoming version are already settled when the current release is out, so there is enough time to update rust-skia. For most new Skia releases, the changes are trivial and are integrated without breaking backwards compatibility on the Rust side.
35
35
36
36
Even though this puts some pressure on dependent projects, we'd try to keep rust-skia updated, because falling behind Chrome's and Flutter's development to keep Skia _modern_ is not an option.
37
-
38
-
But keeping up might not always be possible. So if you use rust-skia, you might be interested to take a look at the [template used](https://github.com/rust-skia/rust-skia/wiki/Template:-Skia-Milestone-Update-PR) to update to the latest Skia version and perhaps even try to help us out from time to time.
37
+
time.
39
38
40
39
## Licensing
41
40
42
-
Please ensure that the material you contribute is compatible with the MIT license.
41
+
Please ensure that the code you contribute is compatible with the MIT license.
0 commit comments