Merge pull request #194 from practical-python-org/bugfix/role-logging-error

fix: Update logging_member_roles.py

Author: Xarlos89

src/zorak/cogs/logging/logging_member_roles.py

@@ -31,22 +31,23 @@ async def on_member_update(self, before, after):
             responsible_member = audit_log.user
 
             changed_roles = []
+            logs_channel = await self.bot.fetch_channel(self.bot.server_settings.log_channel["mod_log"])
             if len(before.roles) > len(after.roles):
                 for role in before.roles:
                     if role not in after.roles:
                         changed_roles.append(role)
                 for item in changed_roles:
                     embed = embed_role_remove(target_member, responsible_member, item)
+                    await logs_channel.send(embed=embed)
 
             elif len(before.roles) < len(after.roles):
                 for role in after.roles:
                     if role not in before.roles:
                         changed_roles.append(role)
                 for item in changed_roles:
                     embed = embed_role_add(target_member, responsible_member, item)
+                    await logs_channel.send(embed=embed)
 
-            logs_channel = await self.bot.fetch_channel(self.bot.server_settings.log_channel["mod_log"])
-            await logs_channel.send(embed=embed)  # Fix - possibly unbound local variable 'embed'
 
 
 def setup(bot):