Skip to content

Commit 19fa561

Browse files
committed
test: temporarily disable gofmt on CI
Temporarily disable gofmt on CI since it'll break when we'll use go 1.10 and go 1.11. A possible solution could be to check against only one (usually the latest stable) go version gofmt output (for example gofmt in go 1.10 and 1.11 will format differently) or check that at least one passes.
1 parent 7973d5d commit 19fa561

File tree

1 file changed

+12
-5
lines changed

1 file changed

+12
-5
lines changed

test

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,11 +41,18 @@ echo "Running tests..."
4141

4242
COVER=${COVER:-"-cover"}
4343

44-
echo "Checking gofmt..."
45-
fmtRes=$(gofmt -l $(find . -type f -name '*.go' ! -path './vendor/*'))
46-
if [ -n "${fmtRes}" ]; then
47-
echo -e "gofmt checking failed:\n${fmtRes}"
48-
exit 255
44+
# Disable gofmt on CI since it'll break when we'll use go 1.10 and go 1.11
45+
#
46+
# TODO(sgotti) Check against only one (usually the latest stable) go version
47+
# gofmt output (for example gofmt in go 1.10 and 1.11 will format differently)
48+
# or check that at least one passes
49+
if [ "${CI}" != "true" ]; then
50+
echo "Checking gofmt..."
51+
fmtRes=$(gofmt -l $(find . -type f -name '*.go' ! -path './vendor/*'))
52+
if [ -n "${fmtRes}" ]; then
53+
echo -e "gofmt checking failed:\n${fmtRes}"
54+
exit 255
55+
fi
4956
fi
5057

5158
echo "Checking govet..."

0 commit comments

Comments
 (0)