Do not form a tuple with unitialized area

za-arthur · za-arthur · commit 8322d6c44e52 · 2018-04-16T12:34:54.000+03:00
diff --git a/src/ruminsert.c b/src/ruminsert.c
@@ -201,6 +201,8 @@ RumFormTuple(RumState * rumstate,
 	{
 		itup = repalloc(itup, newsize);
 
+		memset((char *) itup + IndexTupleSize(itup),
+			   0, newsize - IndexTupleSize(itup));
 		/* set new size in tuple header */
 		itup->t_info &= ~INDEX_SIZE_MASK;
 		itup->t_info |= newsize;
diff --git a/src/rumvacuum.c b/src/rumvacuum.c
@@ -182,6 +182,8 @@ RumFormTuple(RumState * rumstate,
 	{
 		itup = repalloc(itup, newsize);
 
+		memset((char *) itup + IndexTupleSize(itup),
+			   0, newsize - IndexTupleSize(itup));
 		/* set new size in tuple header */
 		itup->t_info &= ~INDEX_SIZE_MASK;
 		itup->t_info |= newsize;

Original file line number	Diff line number	Diff line change
`@@ -201,6 +201,8 @@ RumFormTuple(RumState * rumstate,`
`201`	`201`	`{`
`202`	`202`	`itup = repalloc(itup, newsize);`
`203`	`203`
	`204`	`+ memset((char *) itup + IndexTupleSize(itup),`
	`205`	`+ 0, newsize - IndexTupleSize(itup));`
`204`	`206`	`/* set new size in tuple header */`
`205`	`207`	`itup->t_info &= ~INDEX_SIZE_MASK;`
`206`	`208`	`itup->t_info \|= newsize;`
Original file line number	Diff line number	Diff line change
`@@ -182,6 +182,8 @@ RumFormTuple(RumState * rumstate,`
`182`	`182`	`{`
`183`	`183`	`itup = repalloc(itup, newsize);`
`184`	`184`
	`185`	`+ memset((char *) itup + IndexTupleSize(itup),`
	`186`	`+ 0, newsize - IndexTupleSize(itup));`
`185`	`187`	`/* set new size in tuple header */`
`186`	`188`	`itup->t_info &= ~INDEX_SIZE_MASK;`
`187`	`189`	`itup->t_info \|= newsize;`