We should check only negative return values

za-arthur · za-arthur · commit a0ec849b4a0f · 2018-11-08T18:13:42.000+03:00
diff --git a/src/data.c b/src/data.c
@@ -69,7 +69,7 @@ do_compress(void* dst, size_t dst_size, void const* src, size_t src_size,
 			{
 				int32		ret;
 				ret = zlib_compress(dst, dst_size, src, src_size, level);
-				if (ret != Z_OK && errormsg)
+				if (ret < Z_OK && errormsg)
 					*errormsg = zError(ret);
 				return ret;
 			}
@@ -99,7 +99,7 @@ do_decompress(void* dst, size_t dst_size, void const* src, size_t src_size,
 			{
 				int32		ret;
 				ret = zlib_decompress(dst, dst_size, src, src_size);
-				if (ret != Z_OK && errormsg)
+				if (ret < Z_OK && errormsg)
 					*errormsg = zError(ret);
 				return ret;
 			}

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ do_compress(void* dst, size_t dst_size, void const* src, size_t src_size,`
`69`	`69`	`{`
`70`	`70`	`int32 ret;`
`71`	`71`	`ret = zlib_compress(dst, dst_size, src, src_size, level);`
`72`		`- if (ret != Z_OK && errormsg)`
	`72`	`+ if (ret < Z_OK && errormsg)`
`73`	`73`	`*errormsg = zError(ret);`
`74`	`74`	`return ret;`
`75`	`75`	`}`
`@@ -99,7 +99,7 @@ do_decompress(void* dst, size_t dst_size, void const* src, size_t src_size,`
`99`	`99`	`{`
`100`	`100`	`int32 ret;`
`101`	`101`	`ret = zlib_decompress(dst, dst_size, src, src_size);`
`102`		`- if (ret != Z_OK && errormsg)`
	`102`	`+ if (ret < Z_OK && errormsg)`
`103`	`103`	`*errormsg = zError(ret);`
`104`	`104`	`return ret;`
`105`	`105`	`}`