more informative error message for failed WAL record read

alubennikova · alubennikova · commit 4870fa7f6872 · 2018-11-09T13:59:56.000+03:00
diff --git a/src/parsexlog.c b/src/parsexlog.c
@@ -237,10 +237,11 @@ doExtractPageMap(void *arg)
 	 */
 	if (XLogRecPtrIsInvalid(found))
 	{
-		elog(WARNING, "Thread [%d]: could not read WAL record at %X/%X",
+		elog(WARNING, "Thread [%d]: could not read WAL record at %X/%X. %s",
 			 private_data->thread_num,
 			 (uint32) (extract_arg->startpoint >> 32),
-			 (uint32) (extract_arg->startpoint));
+			 (uint32) (extract_arg->startpoint),
+			 (xlogreader->errormsg_buf[0] != '\0')?xlogreader->errormsg_buf:"");
 		PrintXLogCorruptionMsg(private_data, ERROR);
 	}
 	extract_arg->startpoint = found;

Original file line number	Diff line number	Diff line change
`@@ -237,10 +237,11 @@ doExtractPageMap(void *arg)`
`237`	`237`	`*/`
`238`	`238`	`if (XLogRecPtrIsInvalid(found))`
`239`	`239`	`{`
`240`		`- elog(WARNING, "Thread [%d]: could not read WAL record at %X/%X",`
	`240`	`+ elog(WARNING, "Thread [%d]: could not read WAL record at %X/%X. %s",`
`241`	`241`	`private_data->thread_num,`
`242`	`242`	`(uint32) (extract_arg->startpoint >> 32),`
`243`		`- (uint32) (extract_arg->startpoint));`
	`243`	`+ (uint32) (extract_arg->startpoint),`
	`244`	`+ (xlogreader->errormsg_buf[0] != '\0')?xlogreader->errormsg_buf:"");`
`244`	`245`	`PrintXLogCorruptionMsg(private_data, ERROR);`
`245`	`246`	`}`
`246`	`247`	`extract_arg->startpoint = found;`