Update execute code command for Python -- immediately error when code is incomplete in Python (posit-dev/positron-python#426)

* add wrapper command and use that instead
* prettier
* update unit test expected output

Author: jgutman

extensions/positron-python/package.json

@@ -401,7 +401,7 @@
             },
             {
                 "category": "Python",
-                "command": "workbench.action.positronConsole.executeCode",
+                "command": "python.execSelectionInConsole",
                 "icon": "$(play)",
                 "title": "%python.command.python.execSelectionInConsole.title%"
             },
@@ -1206,6 +1206,12 @@
                 "key": "ctrl+shift+enter",
                 "mac": "cmd+shift+enter",
                 "when": "editorTextFocus && editorLangId == python && !findInputFocussed && !replaceInputFocussed && !jupyter.ownsSelection && !notebookEditorFocused"
+            },
+            {
+                "command": "python.execSelectionInConsole",
+                "key": "ctrl+enter",
+                "mac": "cmd+enter",
+                "when": "editorTextFocus && editorLangId == python && !findInputFocussed && !replaceInputFocussed && !jupyter.ownsSelection && !notebookEditorFocused"
             }
         ],
         "languages": [
@@ -1345,7 +1351,7 @@
                 },
                 {
                     "category": "Python",
-                    "command": "workbench.action.positronConsole.executeCode",
+                    "command": "python.execSelectionInConsole",
                     "title": "%python.command.python.execSelectionInConsole.title%",
                     "when": "!virtualWorkspace && shellExecutionSupported && editorLangId == python"
                 },
@@ -1447,7 +1453,7 @@
             ],
             "python.run": [
                 {
-                    "command": "workbench.action.positronConsole.executeCode",
+                    "command": "python.execSelectionInConsole",
                     "group": "Python",
                     "when": "editorFocus && editorLangId == python && !virtualWorkspace && shellExecutionSupported"
                 },
@@ -1481,7 +1487,7 @@
             ],
             "editor/title/run": [
                 {
-                    "command": "workbench.action.positronConsole.executeCode",
+                    "command": "python.execSelectionInConsole",
                     "group": "navigation@0",
                     "title": "%python.command.python.execSelectionInConsole.title%",
                     "when": "resourceLangId == python && !isInDiffEditor && !virtualWorkspace && shellExecutionSupported"

extensions/positron-python/positron-dts/positron.d.ts

@@ -1098,15 +1098,15 @@ declare module 'positron' {
 		 * @param languageId The language ID of the code snippet
 		 * @param code The code snippet to execute
 		 * @param focus Whether to focus the runtime's console
-		 * @param skipChecks Whether to bypass runtime code completeness checks. If true, the `code`
+		 * @param allowIncomplete Whether to bypass runtime code completeness checks. If true, the `code`
 		 *   will be executed by the runtime even if it is incomplete or invalid. Defaults to false
 		 * @returns A Thenable that resolves with true if the code was sent to a
 		 *   runtime successfully, false otherwise.
 		 */
 		export function executeCode(languageId: string,
 			code: string,
 			focus: boolean,
-			skipChecks?: boolean): Thenable<boolean>;
+			allowIncomplete?: boolean): Thenable<boolean>;
 
 		/**
 		 * Register a language runtime manager with Positron. Returns a

extensions/positron-python/src/client/common/constants.ts

@@ -48,6 +48,7 @@ export namespace Commands {
     export const Exec_In_Separate_Terminal = 'python.execInDedicatedTerminal';
     // --- Start Positron ---
     export const Exec_In_Console = 'python.execInConsole';
+    export const Exec_Selection_In_Console = 'python.execSelectionInConsole';
     // --- End Positron ---
     export const Exec_Selection_In_Django_Shell = 'python.execSelectionInDjangoShell';
     export const Exec_Selection_In_Terminal = 'python.execSelectionInTerminal';

extensions/positron-python/src/client/terminals/codeExecution/codeExecutionManager.ts

@@ -124,6 +124,14 @@ export class CodeExecutionManager implements ICodeExecutionManager {
                 }
             }),
         );
+        this.disposableRegistry.push(
+            this.commandManager.registerCommand(Commands.Exec_Selection_In_Console as any, async () => {
+                // Wrapper for passing the allowIncomplete opt to the console's executeCode command
+                await vscode.commands.executeCommand('workbench.action.positronConsole.executeCode', {
+                    allowIncomplete: true,
+                });
+            }),
+        );
         // --- End Positron ---
         this.disposableRegistry.push(
             this.commandManager.registerCommand(Commands.Exec_Selection_In_Terminal as any, async (file: Resource) => {

extensions/positron-python/src/test/terminals/codeExecution/codeExecutionManager.unit.test.ts

@@ -89,8 +89,9 @@ suite('Terminal - Code Execution Manager', () => {
         expect(sorted).to.deep.equal(
             [
                 // --- Start Positron ---
-                // Add the Positron execute in console command.
+                // Add the Positron execute in console command and execute selection in console command.
                 Commands.Exec_In_Console,
+                Commands.Exec_Selection_In_Console,
                 // --- End Positron ---
                 Commands.Exec_In_Separate_Terminal,
                 Commands.Exec_In_Terminal,