Move data summary setting from "positron" to "dataExplorer" (#7390)

This is an internal, non-fork PR applying the commits from #7263,
because of the problems outlined in #6628

Looking good!

![Screenshot 2025-04-25 at 9 32
32 AM](https://github.com/user-attachments/assets/e49459da-c234-43d1-b840-6eaba45aa982)

### Release Notes

#### New Features

- N/A

#### Bug Fixes

- Improved discoverability of Data Explorer settings, thanks to @kv9898

---------

Signed-off-by: Dianyi Yang <[email protected]>
Co-authored-by: Jonathan McPherson <[email protected]>
Co-authored-by: Dianyi Yang <[email protected]>
Co-authored-by: Dianyi Yang <[email protected]>
Co-authored-by: Brian Lambert <[email protected]>

Author: 4 people

src/vs/workbench/contrib/preferences/browser/settingsLayout.ts

@@ -170,6 +170,13 @@ export const tocData: ITOCEntry<string> = {
 					label: localize('fileExplorer', "Explorer"),
 					settings: ['explorer.*', 'outline.*']
 				},
+				// --- Start Positron ---
+				{
+					id: 'features/dataExplorer',
+					label: localize('positron.dataExplorer', "Data Explorer"),
+					settings: ['dataExplorer.*']
+				},
+				// --- End Positron ---
 				{
 					id: 'features/search',
 					label: localize('search', "Search"),

src/vs/workbench/services/positronDataExplorer/browser/positronDataExplorerSummary.ts

@@ -15,24 +15,24 @@ import { positronConfigurationNodeBase } from '../../languageRuntime/common/lang
 import { PositronDataExplorerLayout } from './interfaces/positronDataExplorerService.js';
 
 // Key for the configuration setting
-export const USE_POSITRON_DATA_EXPLORER_SUMMARY_COLLAPSED_KEY =
-	'positron.dataExplorerSummaryCollapsed';
-export const USE_POSITRON_DATA_EXPLORER_SUMMARY_LAYOUT_KEY =
-	'positron.dataExplorerSummaryLayout';
+export const USE_DATA_EXPLORER_SUMMARY_COLLAPSED_KEY =
+	'dataExplorer.summaryCollapsed';
+export const USE_DATA_EXPLORER_SUMMARY_LAYOUT_KEY =
+	'dataExplorer.summaryLayout';
 
 export function DataExplorerSummaryCollapseEnabled(
 	configurationService: IConfigurationService
 ) {
 	return Boolean(
-		configurationService.getValue(USE_POSITRON_DATA_EXPLORER_SUMMARY_COLLAPSED_KEY)
+		configurationService.getValue(USE_DATA_EXPLORER_SUMMARY_COLLAPSED_KEY)
 	);
 }
 
 export function DefaultDataExplorerSummaryLayout(
 	configurationService: IConfigurationService
 ) {
 	if (String(
-		configurationService.getValue(USE_POSITRON_DATA_EXPLORER_SUMMARY_LAYOUT_KEY)
+		configurationService.getValue(USE_DATA_EXPLORER_SUMMARY_LAYOUT_KEY)
 	) === 'left') {
 		return PositronDataExplorerLayout.SummaryOnLeft;
 	} else {
@@ -48,11 +48,11 @@ configurationRegistry.registerConfiguration({ // for summary collapse
 	...positronConfigurationNodeBase,
 	scope: ConfigurationScope.MACHINE_OVERRIDABLE,
 	properties: {
-		[USE_POSITRON_DATA_EXPLORER_SUMMARY_COLLAPSED_KEY]: {
+		[USE_DATA_EXPLORER_SUMMARY_COLLAPSED_KEY]: {
 			type: 'boolean',
 			default: false,
 			markdownDescription: localize(
-				'positron.enablePositronDataExplorerSummaryCollapse',
+				'positron.dataExplorerSummaryCollapsed',
 				'Collapse Data Explorer Summary Panel by default.'
 			),
 		},
@@ -62,7 +62,7 @@ configurationRegistry.registerConfiguration({ // for summary layout
 	...positronConfigurationNodeBase,
 	scope: ConfigurationScope.MACHINE_OVERRIDABLE,
 	properties: {
-		[USE_POSITRON_DATA_EXPLORER_SUMMARY_LAYOUT_KEY]: {
+		[USE_DATA_EXPLORER_SUMMARY_LAYOUT_KEY]: {
 			type: 'string',
 			default: 'left', // Default value (can be "left" or "right")
 			enum: ['left', 'right'], // Define possible values

src/vs/workbench/services/positronDataExplorer/common/positronDataExplorerExperimentalConfig.ts

@@ -15,8 +15,8 @@ import { positronConfigurationNodeBase } from '../../languageRuntime/common/lang
 import { SupportStatus } from '../../languageRuntime/common/positronDataExplorerComm.js';
 
 // Key for the configuration setting
-export const USE_POSITRON_DATA_EXPLORER_EXPERIMENTAL_KEY =
-	'positron.dataExplorerExperimental';
+export const USE_DATA_EXPLORER_EXPERIMENTAL_KEY =
+	'dataExplorer.Experimental';
 
 /**
  * Retrieves the value of the configuration setting that determines whether to enable
@@ -28,7 +28,7 @@ export function checkDataExplorerExperimentalFeaturesEnabled(
 	configurationService: IConfigurationService
 ) {
 	return Boolean(
-		configurationService.getValue(USE_POSITRON_DATA_EXPLORER_EXPERIMENTAL_KEY)
+		configurationService.getValue(USE_DATA_EXPLORER_EXPERIMENTAL_KEY)
 	);
 }
 
@@ -55,12 +55,12 @@ configurationRegistry.registerConfiguration({
 	...positronConfigurationNodeBase,
 	scope: ConfigurationScope.MACHINE_OVERRIDABLE,
 	properties: {
-		[USE_POSITRON_DATA_EXPLORER_EXPERIMENTAL_KEY]: {
+		[USE_DATA_EXPLORER_EXPERIMENTAL_KEY]: {
 			type: 'boolean',
 			default: false,
 			markdownDescription: localize(
-				'positron.enablePositronDataExplorerExperimentalFeatures',
-				'**CAUTION**: Enable experimental Positron Data Explorer features which may result in unexpected behaviour.'
+				'positron.enableDataExplorerExperimentalFeatures',
+				'**CAUTION**: Enable experimental Data Explorer features which may result in unexpected behavior.'
 			),
 		},
 	},