feedback

Author: austin3dickey

extensions/positron-python/src/client/pythonEnvironments/creation/createEnvApi.ts

@@ -51,8 +51,9 @@ class CreateEnvironmentProviders {
         this._createEnvProviders = [];
     }
 
-    public add(provider: CreateEnvironmentProvider) {
-        // --- Start Positron ---
+    // --- Start Positron ---
+    // Added toTopOfList param
+    public add(provider: CreateEnvironmentProvider, toTopOfList: boolean) {
         if (!isEnvProviderEnabled(provider.id)) {
             traceLog(`${provider.name} environment provider ${provider.id} is not enabled...skipping registration`);
             return;
@@ -62,6 +63,12 @@ class CreateEnvironmentProviders {
         if (this._createEnvProviders.filter((p) => p.id === provider.id).length > 0) {
             throw new Error(`Create Environment provider with id ${provider.id} already registered`);
         }
+        // --- Start Positron ---
+        if (toTopOfList) {
+            this._createEnvProviders.unshift(provider);
+            return;
+        }
+        // --- End Positron ---
         this._createEnvProviders.push(provider);
     }
 
@@ -76,8 +83,14 @@ class CreateEnvironmentProviders {
 
 const _createEnvironmentProviders: CreateEnvironmentProviders = new CreateEnvironmentProviders();
 
-export function registerCreateEnvironmentProvider(provider: CreateEnvironmentProvider): Disposable {
-    _createEnvironmentProviders.add(provider);
+// --- Start Positron ---
+// Added toTopOfList param
+export function registerCreateEnvironmentProvider(
+    provider: CreateEnvironmentProvider,
+    toTopOfList: boolean = false,
+): Disposable {
+    _createEnvironmentProviders.add(provider, toTopOfList);
+    // --- End Positron ---
     return new Disposable(() => {
         _createEnvironmentProviders.remove(provider);
     });
@@ -96,9 +109,6 @@ export async function registerCreateEnvironmentFeatures(
     // --- Start Positron ---
     pythonRuntimeManager: IPythonRuntimeManager,
 ): Promise<void> {
-    if (await isUvInstalled()) {
-        disposables.push(registerCreateEnvironmentProvider(new UvCreationProvider()));
-    }
     // --- End Positron ---
     disposables.push(
         registerCommand(
@@ -159,12 +169,15 @@ export async function registerCreateEnvironmentFeatures(
             },
         ),
         registerCommand(Commands.Get_Conda_Python_Versions, () => getCondaPythonVersions()),
-        registerCommand(Commands.Is_Uv_Installed, async () => isUvInstalled()),
+        registerCommand(Commands.Is_Uv_Installed, async () => await isUvInstalled()),
         registerCommand(Commands.Get_Uv_Python_Versions, () => getUvPythonVersions()),
         registerCommand(Commands.Is_Global_Python, (interpreterPath: string) => isGlobalPython(interpreterPath)),
         // --- End Positron ---
         registerCreateEnvironmentProvider(new VenvCreationProvider(interpreterQuickPick)),
         registerCreateEnvironmentProvider(condaCreationProvider()),
+        // --- Start Positron ---
+        registerCreateEnvironmentProvider(new UvCreationProvider(), await isUvInstalled()),
+        // --- End Positron ---
         onCreateEnvironmentExited(async (e: EnvironmentDidCreateEvent) => {
             if (e.path && e.options?.selectEnvironment) {
                 await interpreterPathService.update(
@@ -176,11 +189,6 @@ export async function registerCreateEnvironmentFeatures(
             }
         }),
     );
-    // --- Start Positron ---
-    if (!(await isUvInstalled())) {
-        disposables.push(registerCreateEnvironmentProvider(new UvCreationProvider()));
-    }
-    // --- End Positron ---
 }
 
 export function buildEnvironmentCreationApi(): ProposedCreateEnvironmentAPI {