DataViewer::execution_thread() protect from panics (#24)

* execution_thread safer from panic

* remove log duplication

* local not used

* save the closure

* + try_local! macro

* actuallt local!() is good enough and gives the same syntax as the try block

* rm junk

Author: romainfrancois

crates/ark/src/data_viewer/r_data_viewer.rs

@@ -35,6 +35,7 @@ use libR_sys::VECTOR_ELT;
 use libR_sys::XLENGTH;
 use serde::Deserialize;
 use serde::Serialize;
+use stdext::local;
 use stdext::spawn;
 use uuid::Uuid;
 
@@ -235,19 +236,22 @@ impl RDataViewer {
     }
 
     pub fn execution_thread(self) {
-        // This is a simplistic version where all the data is converted as once to
-        // a message that is included in initial event of the comm.
-        let json = match DataSet::from_object(self.id.clone(), self.title.clone(), self.data) {
-            Ok(data_set) => serde_json::to_value(data_set).unwrap(),
-            Err(error) => {
-                log::error!("Error while viewing object '{}': {}", self.title, error);
-                return;
-            },
+        let execute: Result<(), anyhow::Error> = local! {
+            // This is a simplistic version where all the data is converted as once to
+            // a message that is included in initial event of the comm.
+            let data_set = DataSet::from_object(self.id.clone(), self.title.clone(), self.data)?;
+            let json = serde_json::to_value(data_set)?;
+
+            let comm_manager_tx = comm_manager_tx();
+            let event = CommEvent::Opened(self.comm.clone(), json);
+            comm_manager_tx.send(event)?;
+
+            Ok(())
         };
 
-        let comm_manager_tx = comm_manager_tx();
-        let event = CommEvent::Opened(self.comm.clone(), json);
-        comm_manager_tx.send(event).unwrap();
+        if let Err(error) = execute {
+            log::error!("Error while viewing object '{}': {}", self.title, error);
+        }
     }
 }