Turn on workspace setting to trim trailing whitespace (#46)

* Trim trailing whitespace and show it when diffing

* Trim trailing whitespace from error files

Author: DavisVaughan

.vscode/settings.json

@@ -16,5 +16,7 @@
     "cmake.configureOnOpen": false,
     "rust-analyzer.showUnlinkedFileNotification": false,
     "files.insertFinalNewline": true,
-    "files.trimFinalNewlines": true
+    "files.trimFinalNewlines": true,
+    "files.trimTrailingWhitespace": true,
+    "diffEditor.ignoreTrimWhitespace": false
 }

crates/ark/src/lsp/modules/private/errors.R

@@ -49,7 +49,7 @@ handle_error_base <- function(cnd) {
     traceback <- lapply(traceback, function(lines) paste0(lines, collapse = "\n"))
     traceback <- as.character(traceback)
     traceback <- paste0(traceback, srcrefs)
-    
+
     .ps.Call("ps_record_error", evalue, traceback)
 }
 
@@ -120,7 +120,7 @@ path_trim_prefix <- function(path, n) {
 handle_error_rlang <- function(cnd) {
     evalue <- rlang::cnd_message(cnd, prefix = TRUE)
     traceback <- cnd$trace
-    
+
     if (is.null(traceback)) {
         traceback <- character()
     } else if (rlang::trace_length(traceback) == 0L) {

crates/ark/src/lsp/modules/public/errors.R

@@ -15,7 +15,7 @@
 
     # Unregister all handlers and hold onto them
     handlers <- globalCallingHandlers(NULL)
-    
+
     # Inject our global error handler at the end.
     # This allows other existing error handlers to run ahead of us.
     handlers <- c(handlers, list(error = .ps.errors.globalErrorHandler))
@@ -27,7 +27,7 @@
     invisible(NULL)
 }
 
-.ps.errors.globalErrorHandler <- function(cnd) {    
+.ps.errors.globalErrorHandler <- function(cnd) {
     if (!is_installed("rlang")) {
         # rlang is not installed, no option except to use the base handler
         return(handle_error_base(cnd))
@@ -36,10 +36,10 @@
         # We have a non-rlang error, but the user requested we dont entrace it
         return(handle_error_base(cnd))
     }
-    
+
     if (!inherits(cnd, "rlang_error")) {
         cnd <- rlang::catch_cnd(rlang::entrace(cnd))
     }
-    
+
     handle_error_rlang(cnd)
 }