Skip to content

Conversation

@ffaf1
Copy link
Contributor

@ffaf1 ffaf1 commented Feb 10, 2025

A number of improvements to hgettext utility:

  1. There is now a test-suite using shellcheck.
  2. Options are now parsed sensibly using optparse-applicative.
  3. hgettext does not break on unicode.
  4. Additional minor bugfixes.

Again I can squash the commits once review is done.

Also ddd shelltestrunner tests.
Print an informative string (like xgettext).
Do not create `message.po` if no file was passed.
i.e. "__"
Also add tests.
Along with a test.
@ffaf1
Copy link
Contributor Author

ffaf1 commented Feb 24, 2025

Rebased on master.

@ffaf1
Copy link
Contributor Author

ffaf1 commented Feb 24, 2025

@portnov If you have got any question I am glad to answer!

If this gets merged, I can help #1 (by asking a reproducer and writing a test).

@portnov
Copy link
Owner

portnov commented Feb 24, 2025

I'll try to look into it this week

@portnov
Copy link
Owner

portnov commented Apr 1, 2025

Hello again.
Sorry for late reply.

I tried to build it with stack build and got

[3 of 3] Compiling Main      
                             
/home/portnov/src/haskell-gettext/exe/Main.hs:13:1: error:
    Could not find module ‘Data.Text.IO.Utf8’
    Use -v to see a list of the files searched for.
   |                         
13 | import qualified Data.Text.IO.Utf8 as Utf8

Maybe you need to change some library version?

@ffaf1
Copy link
Contributor Author

ffaf1 commented Apr 1, 2025

The resolver was quite old, I have bumped it.

Can you try now?

ffaf1 added 6 commits April 1, 2025 07:34
Some sensible changes, including adding signatures where necessary,
qualifying imports, breaking up long lines, adding licences.
@portnov
Copy link
Owner

portnov commented Apr 1, 2025

Yes, now it builds, thanks!

@portnov portnov merged commit e50b324 into portnov:master Apr 1, 2025
@ffaf1 ffaf1 deleted the exe branch April 1, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants