-
Notifications
You must be signed in to change notification settings - Fork 2
Various improvements to hgettext
#3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also ddd shelltestrunner tests.
Print an informative string (like xgettext). Do not create `message.po` if no file was passed.
i.e. "__" Also add tests.
Along with a test.
Contributor
Author
|
Rebased on |
Contributor
Author
Owner
|
I'll try to look into it this week |
Owner
|
Hello again. I tried to build it with Maybe you need to change some library version? |
Contributor
Author
|
The Can you try now? |
Some sensible changes, including adding signatures where necessary, qualifying imports, breaking up long lines, adding licences.
Owner
|
Yes, now it builds, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of improvements to
hgettextutility:shellcheck.optparse-applicative.hgettextdoes not break on unicode.Again I can squash the commits once review is done.