Fix ignoring each table byte offset #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, this GMO parser no considers byte offsets of original and translation tables. So the parsing result is broken. To fix this problem, read these tables at the specified byte offset of the start of the (G)MO file.
Contributor
|
@a5ob7r do you have a reproducer?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for this useful library!
I found a problem about the GMO parser, and this patch fixes it.
Previously, the GMO parser doesn't consider byte offsets of original and translation tables. So the parsing result is broken. To fix this problem, read these tables at the specified byte offset of the start of the (G)MO file.