Improve Flash Message Within openid_connect When auth.info.email is nil

[aaronskiba]

Please complete the following fields as applicable:

What version of the DMPRoadmap code are you running? (e.g. v2.2.0)

• 4.1.1+portage-4.2.3

Current behaviour:
When CILogon is unable to return the auth.info.email attribute, the flash message 'Something went wrong, Please try signing up here.' is rendered (relevant code below):

def openid_connect
  # First or create
  auth = request.env['omniauth.auth']
  user = User.from_omniauth(auth)  

  if auth.info.email.nil? && user.nil?
    flash[:notice] = _('Something went wrong, Please try signing up here.')
    redirect_to new_user_registration_path
    return
  end

Desired behaviour:

• It would be better to provide the user with instructions with how to enable CILogon to return auth.info.email. For example, they could be told to navigate to https://cilogon.org/testidp/ and verify that their chosen IdP is providing all required attributes to CILogon.

[aaronskiba]

Hi @closenma, here is an idea for what the updated flash message could display:

"Unable to sign in with the selected identity provider. Please visit https://cilogon.org/testidp/ to verify that all required fields are provided, or try signing in with another identity provider."

[closenma]

This looks good to me, I'll submit it for translation

[closenma]

The French translation for the string has been returned by Alliance Translation
Vous n’avez pas pu vous connecter en utilisant le fournisseur d’identité sélectionné? Veuillez consulter le site https://cilogon.org/testidp/ pour vérifier que tous les champs requis sont renseignés, ou essayez un autre fournisseur d’identité pour vous connecter.

[aaronskiba]

Hi @closenma,

I'm now realising that in addition to when signing in, this issue can also be encountered by already signed in users attempting to link on the edit profile page. Given that, maybe we need a second string + translation for that case?

If so, here is a suggested addition:

"Unable to link with the selected identity provider. Please visit https://cilogon.org/testidp/ to verify that all required fields are provided, or try linking with another identity provider."

[closenma]

I'll send this one in for translation right away

[closenma]

Translation has returned:
Vous ne parvenez pas à vous connecter via le fournisseur d'identité sélectionné? Veuillez cliquer sur https://cilogon.org/testidp/ pour vérifier que tous les champs requis sont remplis, ou alors vous pouvez essayer de vous connecter à l'aide d'un autre fournisseur d'identité.