Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Unnecessary Copying of Assets When Executing rails commands #956

Open
aaronskiba opened this issue Nov 25, 2024 · 0 comments
Open

Comments

@aaronskiba
Copy link
Collaborator

Please complete the following fields as applicable:

What version of the DMPRoadmap code are you running? (e.g. v2.2.0)

  • 4.1.1+portage-4.2.3

Encountered behaviour:

  • When executing commands like rails c or rails s, etc., the following terminal output is encountered in all environments:
Copying Bootstrap glyphicons to the public directory ...
Copying TinyMCE skins to the public directory ...

The corresponding code exists within config/initializers/assets.rb:

# Bootstrap and TinyMCE expect their files to live in a specific place, so copy them over
puts "Copying Bootstrap glyphicons to the public directory ..."
source_dir = Dir.glob(Rails.root.join('node_modules', 'bootstrap', 'fonts', 'glyphicons-halflings-regular.*'))
destination_dir = Rails.root.join('public', 'fonts', 'bootstrap')
FileUtils.mkdir_p(destination_dir)
FileUtils.cp_r(source_dir, destination_dir)

puts "Copying TinyMCE skins to the public directory ..."
source_dir = Dir.glob(Rails.root.join('node_modules', 'tinymce', 'skins', 'ui', 'oxide'))
destination_dir = Rails.root.join('public', 'tinymce', 'skins')
FileUtils.mkdir_p(destination_dir)
FileUtils.cp_r(source_dir, destination_dir)

Remedy:
Move this aforementioned code outside of config/initializers/ (Perhaps it'd be best if it was only executed as part of rails assets:precompile?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant