Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoclose sounds wrong for bamboo, cherry, nether, copper doors, trapdoors, fence gates #244

Open
GriffinCodes opened this issue Feb 18, 2025 · 3 comments
Labels
bug Something isn't working

Comments

@GriffinCodes
Copy link

When a door/trapdoor/gate closes via autoclose, LWC plays the wooden sound for everything except iron doors. There are separate sounds for bamboo, cherry, nether, and copper doors.

Ref:
https://minecraft.wiki/w/Wooden_Door#Unique
https://minecraft.wiki/w/Wooden_Trapdoor#Unique
https://minecraft.wiki/w/Copper_Door#Other
https://minecraft.wiki/w/Copper_Trapdoor#Opening

@pop4959 pop4959 added the bug Something isn't working label Feb 20, 2025
@pop4959
Copy link
Owner

pop4959 commented Feb 20, 2025

There hasn't been a good way to get the unique sound for a door, so aside from manually updating the door sounds every update this has been a bit annoying to keep up with. It's possible there is a better solution, so this is something that will be looked into at some point. However it is fairly low priority.

@GriffinCodes
Copy link
Author

ProjectEdenGG/Nexus@32fb8b1

Not sure how you feel about using NMS in LWCX, but this would work in 1.21 for any material (not just the ones listed above), not sure about other versions. BlockSetType doesnt support fence gates for some reason, so I did some string replacements instead. It seems future proof enough to me. Feel free to use it if you like it.

@pop4959
Copy link
Owner

pop4959 commented Feb 22, 2025

No plans for NMS currently, API would need to be added if it isn't already for this to make it's way into LWC. Especially for such a minor issue, it would still be better to just manually add the sounds in a way that is supported by API. You're welcome to PR if you need this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants