Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta Tags, OpenGraph and Twitter Cards #223

Closed
shaedrich opened this issue May 24, 2024 · 2 comments · Fixed by #227
Closed

Meta Tags, OpenGraph and Twitter Cards #223

shaedrich opened this issue May 24, 2024 · 2 comments · Fixed by #227

Comments

@shaedrich
Copy link
Contributor

shaedrich commented May 24, 2024

Related to ponylang/pony-tutorial#546

This could be implemented statically into static/web.html at first, but it would make sense to prospectively make it dynamic by converting it to a template and creating the tags depending on the Query params.

I know, I'm crazy, but one should be allowed to dream every once in a while 😉

@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label May 24, 2024
@shaedrich
Copy link
Contributor Author

I went ahead and made an example implementation of how the static variant would look: #227

@shaedrich
Copy link
Contributor Author

I also added a PR for the dynamic implementation, that would be necessary for snippet filenames as titles as well as a description: #228

I haven't tested this one yet, but this would be the directed for the implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants