Skip to content

ABI 0.2 (part 1/2) #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 21 commits into
base: wrap-0.2-dev
Choose a base branch
from
Open

ABI 0.2 (part 1/2) #3

wants to merge 21 commits into from

Conversation

@namesty
Copy link

@namesty namesty commented Jan 18, 2023 •
edited
Loading

This PR includes:

  • New ABI types
  • Usage examples
  • New JSONSchema
  • Documentation on introduced concepts, decisions made, future plans

dOrgJelli and others added 20 commits December 30, 2022 16:11
@dOrgJelli
initial abi 0.2 draft
e8167fa
@dOrgJelli
update method example
ae3c2ca
@dOrgJelli
updates based on Nestor's feedback
02bc914
@namesty
(feat): added required properties to inner types in Arrays and Maps
bda9587
@namesty
(chore): Array and Map show cases
1281fdc
@namesty
(chore): removed unnecessary nesting
cfcd3ce
@namesty
removed unnecessary nesting
b894582
@dOrgJelli
updates
6d87716
@dOrgJelli
Nestor & Jordan updates
ac78423
@namesty
(wip): added further decisions to readme
19f76d8
@namesty
(chore): added imports example
09eacbd
@namesty
(chore): added enum and implement cases
6f9e960
@namesty
(feat): added experiments for embedding and namespacing
43550c3
@namesty
(chore): added local peer dep case
0db0512
@namesty
(chore): settled for namespacing everything. Import an import
dd1b48c
@namesty
Merge branch 'imports-playground' into abi-0.2
03e2dd1
@namesty
(chore): added future plans and ABI routing
998f0c2
@dOrgJelli
add importType + start json schema
664d2f7
@namesty
(chore): updated examples and todos
0465ebd
@namesty
(feat): added jsonschema
86cc273
@dOrgJelli
Copy link
Contributor

dOrgJelli commented Jan 20, 2023

Do we want to target a different branch that will act as more of a "staging" branch for wrap 0.2? I think wrap-0-2 is currently pretty heavily under development with the work @nerfZael and @Niraj-Kamdar are doing at the moment. Maybe we should:

  1. create a wrap-0.2-dev branch from master.
  2. rename the wrap-0-2 branch you all are working in to something more specific to the standards you all are working on.

@Niraj-Kamdar Niraj-Kamdar self-requested a review February 3, 2023 11:48
Niraj-Kamdar
Niraj-Kamdar reviewed Feb 7, 2023
View reviewed changes
Copy link
Contributor

@Niraj-Kamdar Niraj-Kamdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left some comments.

abi/examples/imports/foo.ts
{
uri: "lib2",
type: "wasm",
id: "0",
Copy link
Contributor

@Niraj-Kamdar Niraj-Kamdar Feb 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if we use IPFS hash of the abi as id?
It's guaranteed to be unique and since content addressable no need to embed the imported abi.

Copy link
Contributor

@dOrgJelli dOrgJelli Feb 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The goal of the "id" is to be a (1) small in size & (2) efficient to lookup (i.e. strcmp). The URI does not satisfy these things in my opinion.

Copy link
Contributor

@Niraj-Kamdar Niraj-Kamdar Feb 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it has its own benefits as I discussed and we should compare both and see which is a better way going forward.

@Niraj-Kamdar Niraj-Kamdar changed the base branch from wrap-0-2 to wrap-0.2-dev February 17, 2023 16:40
@dOrgJelli
Copy link
Contributor

dOrgJelli commented Feb 19, 2023

Responded @Niraj-Kamdar, would you feel comfortable approving in its current state?

@dOrgJelli dOrgJelli changed the title ABI 0.2 ABI 0.2 (part 1/2) Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dOrgJelli dOrgJelli dOrgJelli left review comments

@nerfZael nerfZael nerfZael approved these changes

+1 more reviewer

@Niraj-Kamdar Niraj-Kamdar Niraj-Kamdar left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@namesty @dOrgJelli @nerfZael @Niraj-Kamdar