build: linting changes after running ruff

Author: polyccon

run.py

@@ -1,4 +1,4 @@
 from src.views import app
 
-if __name__ == '__main__':
-    app.run(debug= True, port=5500, host='0.0.0.0')
+if __name__ == "__main__":
+    app.run(debug=True, port=5500, host="0.0.0.0")

src/core.py

@@ -2,5 +2,5 @@
 
 
 app = Flask(__name__)
-app.config['DEBUG'] = True
-app.config['ENV'] = 'development'
+app.config["DEBUG"] = True
+app.config["ENV"] = "development"

src/data/convert_data.py

@@ -19,7 +19,9 @@ def fetch_crime_data(self) -> None:
         """Fetch crime data only when needed."""
         if not self.crime_data:
             latitude, longitude = self.location_client.postcode_to_coordinates()
-            self.crime_data = self.police_client.get_data_for_coordinates(latitude, longitude)
+            self.crime_data = self.police_client.get_data_for_coordinates(
+                latitude, longitude
+            )
 
     def extract_specific_data(self, key: str) -> List:
         """Helper function to count occurrences of a given key in crime data."""
@@ -32,12 +34,12 @@ def extract_specific_data(self, key: str) -> List:
                 topic = topic.get("category", "Unknown") if topic else "Unknown"
             d[topic] += 1
 
-        return [{'label': k, 'value': v} for k, v in d.items()]
+        return [{"label": k, "value": v} for k, v in d.items()]
 
     def get_crime_categories(self) -> List:
         """Extracts crime categories."""
         return self.extract_specific_data("category")
 
     def get_crime_outcomes(self) -> List:
         """Extracts crime outcomes."""
-        return self.extract_specific_data("outcome_status")
+        return self.extract_specific_data("outcome_status")

src/services/location_client.py

@@ -9,7 +9,7 @@ def __init__(self, location):
     def postcode_to_coordinates(self):
         url = f"http://api.postcodes.io/postcodes/{self.location}"
         resp_postcode = requests.get(url=url)
-        data = json.loads(resp_postcode.text)['result']
-        latitude = data['latitude']
-        longitude = data['longitude']
-        return latitude, longitude
+        data = json.loads(resp_postcode.text)["result"]
+        latitude = data["latitude"]
+        longitude = data["longitude"]
+        return latitude, longitude

src/services/police_client.py

@@ -2,15 +2,12 @@
 import requests
 
 
-class PoliceClient():
+class PoliceClient:
     def __init__(self):
         pass
 
     def get_data_for_coordinates(self, latitude, longitude):
-        url = 'https://data.police.uk/api/crimes-street/all-crime?'
-        params = dict(
-            lat=latitude,
-            lng=longitude
-        )
+        url = "https://data.police.uk/api/crimes-street/all-crime?"
+        params = dict(lat=latitude, lng=longitude)
         resp = requests.get(url=url, params=params)
-        return json.loads(resp.text)
+        return json.loads(resp.text)

src/views.py

@@ -8,46 +8,43 @@ def _parse_request_body():
     """Extract data type from request body."""
     request_body = request.get_json()
     try:
-        id_ = request_body['id']
-        items = request_body['items']
+        id_ = request_body["id"]
+        items = request_body["items"]
         return id_, items
     except KeyError:
         # Missing necessary fields.
-        response_body = {
-            'error':
-            "'id', 'items' key in request body"
-        }
+        response_body = {"error": "'id', 'items' key in request body"}
         abort(make_response(jsonify(response_body), 400))
 
 
-@app.route('/healthz', methods=['GET'])
+@app.route("/healthz", methods=["GET"])
 def healthz():
-    return '', 200
+    return "", 200
 
 
 @app.route("/")
 def hello():
-    return render_template('home.html')
+    return render_template("home.html")
 
 
 @app.route("/home")
 def home():
     return redirect("/")
 
 
-@app.route('/category_data/<location>')
+@app.route("/category_data/<location>")
 def category_data(location):
     processor = CrimeDataProcessor(location)
     return jsonify(processor.get_crime_categories())
 
 
-@app.route('/outcome_data/<location>')
+@app.route("/outcome_data/<location>")
 def outcome_data(location):
     processor = CrimeDataProcessor(location)
     return jsonify(processor.get_crime_outcomes())
 
 
-@app.route('/viewcrime', methods=['GET', 'POST'])
+@app.route("/viewcrime", methods=["GET", "POST"])
 def viewcrime():
-    postcode = request.form['postcode']
-    return render_template('results.html', location=postcode)
+    postcode = request.form["postcode"]
+    return render_template("results.html", location=postcode)

tests/test_crime_data_processor.py

@@ -1,9 +1,9 @@
 import pytest
-from unittest.mock import patch, MagicMock
+from unittest.mock import patch
 
 from src.data.convert_data import CrimeDataProcessor
 
-# Mock data
+
 MOCK_COORDINATES = (51.5074, -0.1278)  # London example
 MOCK_CRIME_DATA = [
     {"category": "burglary", "outcome_status": {"category": "Under investigation"}},
@@ -12,17 +12,19 @@
     {"category": "theft", "outcome_status": {"category": "Under investigation"}},
 ]
 
+
 @pytest.fixture
 def mock_processor():
     """Fixture to create a CrimeDataProcessor with mocked API calls."""
-    with patch("src.data.convert_data.LocationClient") as MockLocationClient, \
-         patch("src.data.convert_data.PoliceClient") as MockPoliceClient:
-
-        # Mock LocationClient behavior
+    with (
+        patch("src.data.convert_data.LocationClient") as MockLocationClient,
+        patch("src.data.convert_data.PoliceClient") as MockPoliceClient,
+    ):
+        # Mock LocationClient behaviour
         mock_location = MockLocationClient.return_value
         mock_location.postcode_to_coordinates.return_value = MOCK_COORDINATES
 
-        # Mock PoliceClient behavior
+        # Mock PoliceClient behaviour
         mock_police = MockPoliceClient.return_value
         mock_police.get_data_for_coordinates.return_value = MOCK_CRIME_DATA
 
@@ -33,7 +35,7 @@ def test_get_crime_categories(mock_processor):
     """Test if categories are counted correctly."""
     expected_result = [
         {"label": "burglary", "value": 2},
-        {"label": "theft", "value": 2}
+        {"label": "theft", "value": 2},
     ]
     assert mock_processor.get_crime_categories() == expected_result
 
@@ -52,9 +54,18 @@ def test_get_crime_outcomes(mock_processor):
 def test_fetch_crime_data_calls_api_once(mock_processor):
     """Ensure postcode_to_coordinates and get_data_for_coordinates are only called once."""
 
-    with patch.object(mock_processor.location_client, "postcode_to_coordinates", return_value=(51.5074, -0.1278)) as mock_location, \
-         patch.object(mock_processor.police_client, "get_data_for_coordinates", return_value=[{"category": "theft"}]) as mock_police:
-
+    with (
+        patch.object(
+            mock_processor.location_client,
+            "postcode_to_coordinates",
+            return_value=(51.5074, -0.1278),
+        ) as mock_location,
+        patch.object(
+            mock_processor.police_client,
+            "get_data_for_coordinates",
+            return_value=[{"category": "theft"}],
+        ) as mock_police,
+    ):
         mock_processor.get_crime_categories()
         mock_processor.get_crime_outcomes()