Plain comparison only works with primitives

Comparing with an array will result in an error.

I tried to see if I could implement comparison with an array, but that
doesn't seem possible as you need to know the array type in postgres,
which we don't.

Author: erikdubbelboer

filter/converter.go

@@ -167,6 +167,9 @@ func (c *Converter) convertFilter(filter map[string]any, paramIndex int) (string
 				}
 				conditions = append(conditions, innerResult)
 			default:
+				if !isScalar(value) {
+					return "", nil, fmt.Errorf("invalid comparison value (must be a primitive): %v", value)
+				}
 				conditions = append(conditions, fmt.Sprintf("(%s = $%d)", c.columnName(key), paramIndex))
 				paramIndex++
 				values = append(values, value)

filter/converter_test.go

@@ -216,6 +216,14 @@ func TestConverter_Convert(t *testing.T) {
 			nil,
 			fmt.Errorf("invalid column name: \"bla = 1 --"),
 		},
+		{
+			"compare with array",
+			nil,
+			`{"items": [200, 300]}`,
+			``,
+			nil,
+			fmt.Errorf("invalid comparison value (must be a primitive): [200 300]"),
+		},
 	}
 
 	for _, tt := range tests {