Tightened down a few more screws

Author: pglewis

admin/class-pods-export-code.php

@@ -7,21 +7,22 @@ class Pods_Export_Code_Admin {
 	/**
 	 * Instance of this class.
 	 *
-	 * @since    1.0.0
-	 *
 	 * @var      object
 	 */
 	protected static $instance = null;
 
 	/**
 	 * Slug of the plugin screen.
 	 *
-	 * @since    1.0.0
-	 *
 	 * @var      string
 	 */
 	protected $plugin_screen_hook_suffix = null;
 
+	/**
+	 * @var array
+	 */
+	protected $exportable_pods = array();
+
 	/**
 	 * Initialize the plugin by loading admin scripts & styles and adding a
 	 * settings page and menu.
@@ -147,7 +148,22 @@ public function add_plugin_admin_menu ( $admin_menus ) {
 	 * @since    1.0.0
 	 */
 	public function display_plugin_admin_page () {
-		include_once( 'views/admin.php' );
+
+		$this->set_exportable_pods();
+		if ( count( $this->exportable_pods() ) > 0 ) {
+			include_once( 'views/admin.php' );
+		}
+		else {
+			include_once( 'views/admin-no-pods.php' );
+		}
+
+	}
+
+	/**
+	 * @return array|null
+	 */
+	public function exportable_pods() {
+		return $this->exportable_pods;
 	}
 
 	/**
@@ -171,4 +187,25 @@ public function pods_export_code () {
 
 		die();
 	}
+
+	/**
+	 *
+	 */
+	private function set_exportable_pods() {
+
+		$this->exportable_pods = array();
+
+		$pods = pods_api()->load_pods( array( 'fields' => false ) );
+		foreach ( $pods as $this_pod ) {
+
+			// We only support meta-based Pods
+			if ( 'table' == $this_pod[ 'storage' ] ) {
+				continue;
+			}
+
+			$this->exportable_pods[] = $this_pod;
+		}
+
+	}
+
 }

admin/classes/pods-export-code-api.php

@@ -26,16 +26,15 @@ public function export_pod ( $pod_name ) {
 
 		$output = '';
 
-		// Attempt to load the pod
-		// ToDo: test with bad pod names
+		// Attempt to load the pod, don't throw an exception on error
 		$params = array(
 			'name'   => $pod_name,
 			'fields' => true,
 		);
-		$pod = $this->api->load_pod( $params );
+		$pod = $this->api->load_pod( $params, false );
 
-		// We only support meta-based Pods
-		if ( 'table' == $pod[ 'storage' ] ) {
+		// Exit if the pod wasn't found or is table based (not supported)
+		if ( false === $pod || !isset( $pod[ 'storage' ] ) || 'table' == $pod[ 'storage' ] ) {
 			return '';
 		}
 

admin/views/admin-no-pods.php

@@ -0,0 +1,11 @@
+<div class="wrap">
+
+	<?php screen_icon( 'options-general' ); ?>
+	<h2><?php echo esc_html( get_admin_page_title() ); ?></h2>
+
+	<div class="updated">
+		<p>
+			There are no Pods to export.
+		</p>
+	</div>
+</div>

admin/views/admin.php

@@ -1,3 +1,4 @@
+<?php /** @global Pods_Export_Code_Admin $this */ ?>
 <div class="wrap">
 
 	<?php screen_icon( 'options-general' ); ?>
@@ -16,14 +17,8 @@
 					<div class="pods-pick-values pods-pick-checkbox pods-zebra">
 						<ul>
 							<?php
-							$pods = pods_api()->load_pods( array( 'fields' => false ) );
 							$zebra = false;
-							foreach ( $pods as $this_pod ) {
-
-								// We only support meta-based Pods
-								if ( 'table' == $this_pod[ 'storage' ] ) {
-									continue;
-								}
+							foreach ( $this->exportable_pods() as $this_pod ) {
 
 								$class = ( $zebra ? 'even' : 'odd' );
 								$zebra = ( !$zebra );