Skip to content

refactor(backend): skip quadlet failing QuadletDryrunParser to avoid blocking parsing #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

refactor(backend): skip quadlet failing QuadletDryrunParser to avoid blocking parsing #762

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca236e2
chore(backend): adding console.warn for quadlet version
axel7083 Jul 18, 2025
06cfd1a
feat: skipping quadlet failing to parse
axel7083 Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/backend/src/services/quadlet-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ import { isRunError } from '../utils/run-error';
import templates from '../assets/templates.json';
import type { Template } from '/@shared/src/models/template';
import type { PodmanWorker } from '../utils/worker/podman-worker';
import { lt, coerce } from 'semver';

export const QUADLET_MIN_STABLE = '5.3.0';

export class QuadletService extends QuadletHelper implements Disposable, AsyncInit {
#extensionsEventDisposable: Disposable | undefined;
Expand Down Expand Up @@ -192,6 +195,12 @@ export class QuadletService extends QuadletHelper implements Disposable, AsyncIn
`[QuadletService] found quadlet version ${quadletVersion} for connection ${provider.connection.name} of provider ${provider.providerId}`,
);

// warn user depending on quadlet version
const coerced = coerce(quadletVersion);
if (coerced && lt(coerced, QUADLET_MIN_STABLE)) {
console.warn(`connection ${provider.connection.name} uses an old quadlet version: ${quadletVersion}`);
}

// 3. get the quadlets
const quadlets = await this.getPodmanQuadlets({ provider, admin: false });

Expand Down
8 changes: 6 additions & 2 deletions packages/backend/src/utils/parsers/quadlet-dryrun-parser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,12 @@ export class QuadletDryRunParser extends Parser<RunResult & { exitCode?: number
const serviceName = match[1].trim();

// parse the quadlet unit
const quadletUnitParser = new QuadletUnitParser(serviceName, match[2].trim());
this.services[serviceName] = quadletUnitParser.parse();
try {
const quadletUnitParser = new QuadletUnitParser(serviceName, match[2].trim());
this.services[serviceName] = quadletUnitParser.parse();
} catch (err: unknown) {
console.error(`cannot parse ${serviceName}`, err);
}
}

this.parsed = true;
Expand Down