Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update globals to avoid build failure #1253

Closed
deboer-tim opened this issue Jan 31, 2025 · 0 comments · Fixed by #1254
Closed

Update globals to avoid build failure #1253

deboer-tim opened this issue Jan 31, 2025 · 0 comments · Fixed by #1254
Assignees
Labels
kind/bug 🐞 Something isn't working sprint/unplanned

Comments

@deboer-tim
Copy link
Contributor

Bug description

Several PRs (#1228 #1250 #1251 #1252) are currently failing due to the same error:
TypeError: Key "languageOptions": Key "globals": Global "AudioWorkletGlobalScope " has leading or trailing whitespace.

This is due to a bug in globals that was fixed a while ago, but some packages are still picking it up: sindresorhus/globals#239

% npm ls globals
[email protected] /Users/deboer/git/pd-extension-bootc
├─┬ [email protected]
│ ├─┬ @babel/[email protected]
│ │ └─┬ @babel/[email protected]
│ │   └── [email protected]
│ └─┬ @babel/[email protected]
│   └─┬ @babel/[email protected]
│     └── [email protected] deduped
├─┬ [email protected]
│ └── [email protected]
└─┬ [email protected] invalid: "^8.0.0" from node_modules/eslint-plugin-etc, "^8.46.0" from node_modules/eslint-plugin-redundant-undefined
  └─┬ @eslint/[email protected]
    └── [email protected]

This could be fixed within any of those PRs, but I'm using a new issue & separate PR since it affects multiple PRs, and to make sure this is easily found later.

Operating system

macOS

Version

next (development version)

Steps to reproduce

No response

Relevant log output

Additional context

No response

@deboer-tim deboer-tim added kind/bug 🐞 Something isn't working sprint/unplanned labels Jan 31, 2025
@deboer-tim deboer-tim self-assigned this Jan 31, 2025
deboer-tim added a commit that referenced this issue Jan 31, 2025
See issue for details - picking up older globals is causing lint failures so
adding a direct dependency.

Fixes #1253.

Signed-off-by: Tim deBoer <[email protected]>
@deboer-tim deboer-tim moved this to 🚥 In Review in Podman Desktop Planning OLD Jan 31, 2025
@github-project-automation github-project-automation bot moved this from 🚥 In Review to ✔️ Done in Podman Desktop Planning OLD Jan 31, 2025
@nichjones1 nichjones1 moved this to ✔️ Done in Podman Desktop Planning Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug 🐞 Something isn't working sprint/unplanned
Projects
Status: ✔️ Done
Development

Successfully merging a pull request may close this issue.

1 participant