Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Card children to svelte 5 #1206

Closed
deboer-tim opened this issue Jan 21, 2025 · 0 comments · Fixed by #1208
Closed

Update Card children to svelte 5 #1206

deboer-tim opened this issue Jan 21, 2025 · 0 comments · Fixed by #1208
Assignees
Labels
kind/enhancement ✨ Issue for requesting an improvement

Comments

@deboer-tim
Copy link
Contributor

Is your enhancement related to a problem? Please describe

Every build outputs the following deprecation warning:

[0] 9:22:10 a.m. [vite-plugin-svelte] src/lib/Card.svelte:26:6 Using `<slot>` to render parent content is deprecated. Use `{@render ...}` tags instead
[0] https://svelte.dev/e/slot_element_deprecated
[0] 24:     </div>
[0] 25:     <div class="flex overflow-hidden" role="region" aria-label="content">
[0] 26:       <slot name="content" />
[0]                                  ^
[0] 27:     </div>
[0] 28:   </div>

Describe the solution you'd like

The rest of Card is already using svelte 5, just update the child rendering.

Describe alternatives you've considered

No response

Additional context

No response

@deboer-tim deboer-tim added the kind/enhancement ✨ Issue for requesting an improvement label Jan 21, 2025
@deboer-tim deboer-tim self-assigned this Jan 21, 2025
deboer-tim added a commit to deboer-tim/podman-desktop-extension-bootc that referenced this issue Jan 21, 2025
Just updates the child rendering to svelte 5 to remove the build warning. Since
this is the only slot I just removed the name for simplicity.

Fixes podman-desktop#1206.

Signed-off-by: Tim deBoer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement ✨ Issue for requesting an improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant