Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"bootc" label not shown on image list in dark mode #1174

Closed
vrothberg opened this issue Jan 13, 2025 · 1 comment · Fixed by #1285
Closed

"bootc" label not shown on image list in dark mode #1174

vrothberg opened this issue Jan 13, 2025 · 1 comment · Fixed by #1285
Assignees
Labels
kind/bug 🐞 Something isn't working
Milestone

Comments

@vrothberg
Copy link
Contributor

Bug description

I need to hover over the item to see the "bootc" label but it's not being displayed (or visible) by default.

Image

Operating system

macOS

Version

next (development version)

Steps to reproduce

No response

Relevant log output

Additional context

No response

@vrothberg vrothberg added the kind/bug 🐞 Something isn't working label Jan 13, 2025
@cdrage cdrage added this to the 1.7 milestone Jan 13, 2025
@cdrage cdrage self-assigned this Jan 13, 2025
@cdrage cdrage moved this to 📋 Backlog in Podman Desktop Planning Jan 13, 2025
@deboer-tim
Copy link
Contributor

I ran into this today and took a quick look. The original way to customize the color (providing a color from Podman Desktop's Tailwind palette) was error prone, but something else broke first. I'm not sure it's worth investigating anyway, especially as specifying a color value works, e.g.:

"badges/image": [
        {
          "badge": {
            "color": {
              "dark": "#7dd3fc",
              "light": "#7dd3fc"
            }

@cdrage cdrage moved this from 📋 Backlog to 🚧 In Progress in Podman Desktop Planning Jan 27, 2025
cdrage added a commit to cdrage/podman-desktop-extension-bootc that referenced this issue Feb 5, 2025
### What does this PR do?

Fixes the colour showing in dark / light mode on the image page. As
before it was not picking up the tailwind-specific colour.

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes podman-desktop#1174

### How to test this PR?

<!-- Please explain steps to reproduce -->

1.Pull a bootc test image
2. See that the label shows now

Signed-off-by: Charlie Drage <[email protected]>
@cdrage cdrage moved this from 🚧 In Progress to 🚥 In Review in Podman Desktop Planning Feb 5, 2025
@cdrage cdrage closed this as completed in 6bdc25f Feb 5, 2025
@github-project-automation github-project-automation bot moved this from 🚥 In Review to ✔️ Done in Podman Desktop Planning Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants